Replace context enter and exit events with single "context switched" event
まだ誰も着手していません。
- 主要言語
- Python
- スター
- 77.2k
- フォーク
- 35.9k
- PR マージ指標
- PR 指標を取得中
説明
Feature or enhancement
Proposal:
(split off of https://github.com/python/cpython/issues/99633#issuecomment-2380302948 to keep related pull requests and discussion better organized)
Starting in v3.14, C code can subscribe to "context enter" and "context exit" events:
See gh-119333 for some background.
I would like to replace the just-added "context enter" and "context exit" events with a single "context switched" event:
diff --git a/Include/cpython/context.h b/Include/cpython/context.h
index ec72966e82c..f9638b0abe5 100644
--- a/Include/cpython/context.h
+++ b/Include/cpython/context.h
@@ -28,8 +28,12 @@ PyAPI_FUNC(int) PyContext_Enter(PyObject *);
PyAPI_FUNC(int) PyContext_Exit(PyObject *);
typedef enum {
- Py_CONTEXT_EVENT_ENTER,
- Py_CONTEXT_EVENT_EXIT,
+ /*
+ * The current context has switched to a different context. The object
+ * passed to the watch callback is the now-current contextvars.Context
+ * object.
+ */
+ Py_CONTEXT_SWITCHED = 1,
} PyContextEvent;
/*
diff --git a/Python/context.c b/Python/context.c
index ddb03555f9e..6c9f68583c2 100644
--- a/Python/context.c
+++ b/Python/context.c
@@ -192,7 +192,7 @@ _PyContext_Enter(PyThreadState *ts, PyObject *octx)
ts->context = Py_NewRef(ctx);
ts->context_ver++;
- notify_context_watchers(Py_CONTEXT_EVENT_ENTER, ctx, ts);
+ notify_context_watchers(Py_CONTEXT_SWITCHED, ctx, ts);
return 0;
}
@@ -226,13 +226,13 @@ _PyContext_Exit(PyThreadState *ts, PyObject *octx)
return -1;
}
- notify_context_watchers(Py_CONTEXT_EVENT_EXIT, ctx, ts);
Py_SETREF(ts->context, (PyObject *)ctx->ctx_prev);
ts->context_ver++;
ctx->ctx_prev = NULL;
ctx->ctx_entered = 0;
+ notify_context_watchers(Py_CONTEXT_SWITCHED, (PyContext *)ts->context, ts);
return 0;
}
Rationale: Users want to know when the current context switches to a different context object. Right now this happens when and only when a context is entered or exited, so the enter and exit events are synonymous with "switched". However, if the changes proposed for gh-99633 are implemented, the current context will also switch for reasons other than context enter or exit. Since users actually care about context switches and not enter or exit, replacing the enter and exit events with a single switched event would make the new feature compatible with gh-99633.
The current "context exit" event is emitted just before exiting the context. The new "context switched" event would be emitted after the context is exited to match the semantics users expect of an event with a past-tense name. If users need the ability to clean up before the switch takes effect, another "context is about to switch" event can be added in the future. I am not proposing to add such an event for this issue because no users have requested it yet (YAGNI).
I would love to get this resolved before v3.14 is released so that we don't have to worry about breaking backwards compatibility.
Has this already been discussed elsewhere?
I have already discussed this feature proposal on another bug report.
Links to previous discussion of this feature:
https://github.com/python/cpython/issues/99633#issuecomment-2380302948
Linked PRs
- gh-124774
- gh-124773
- gh-124741
- gh-124737
- gh-124776
- gh-125233
- gh-125285
- gh-125532
- gh-125638
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
調査の方向性
Include/cpython/context.h と Python/context.c から始め、次に gh-99633 にリンクされている議論と、そこに記載されたリンク先の PR を読んでください。提案で説明されている単一の post-switch event に enter イベントと exit イベントを置き換え、Python 3.14 より前に意図されている互換性を維持できれば完了です。
索引モデルが issue の本文から書いたものです。
評価
- 技術スタック
- c, python
- 領域
- api, backend
- issue の種類
- 機能追加
- 難易度
- 5/5
- 見積もり時間
- 1週間以上
- 活発さ
- 停滞
- 明瞭さ
- 明確に書かれている
- 初心者へのやさしさ
- 25/100