python / python/cpython

make pyrepl more robust against crashes

未关闭
#122,468 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

topic-repl type-bug
主要语言
Python
星标
77.2k
派生
35.9k
PR 合并指标
PR 指标待抓取

描述

Bug report

Bug description:

This issue is motivated by a discussion with @serhiy-storchaka on #122456. Pyrepl/code.InteractiveInterpreter does not handle exceptions at various points, see the linked commend for an example.

Directly after writing this, I also got the following traceback that I now can't reproduce, by pressing ctrl-r then searching for a string, and then pressing ctrl-c at somehow the wrong point:

>>> Traceback (most recent call last):
  File "/home/cfbolz/projects/cpython/Lib/_pyrepl/simple_interact.py", line 147, in run_multiline_interactive_console
    statement = multiline_input(more_lines, ps1, ps2)
  File "/home/cfbolz/projects/cpython/Lib/_pyrepl/readline.py", line 385, in multiline_input
    return reader.readline()
           ~~~~~~~~~~~~~~~^^
  File "/home/cfbolz/projects/cpython/Lib/_pyrepl/reader.py", line 773, in readline
    self.handle1()
    ~~~~~~~~~~~~^^
  File "/home/cfbolz/projects/cpython/Lib/_pyrepl/reader.py", line 730, in handle1
    event = self.console.get_event(block)
  File "/home/cfbolz/projects/cpython/Lib/_pyrepl/unix_console.py", line 391, in get_event
    self.push_char(self.__read(1))
                   ~~~~~~~~~~~^^^
  File "/home/cfbolz/projects/cpython/Lib/_pyrepl/unix_console.py", line 203, in __read
    self.input_buffer = os.read(self.input_fd, 10000)
                        ~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
KeyboardInterrupt

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "<frozen runpy>", line 198, in _run_module_as_main
  File "<frozen runpy>", line 88, in _run_code
  File "/home/cfbolz/projects/cpython/Lib/_pyrepl/__main__.py", line 6, in <module>
    __pyrepl_interactive_console()
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
  File "/home/cfbolz/projects/cpython/Lib/_pyrepl/main.py", line 59, in interactive_console
    run_multiline_interactive_console(console)
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
  File "/home/cfbolz/projects/cpython/Lib/_pyrepl/simple_interact.py", line 164, in run_multiline_interactive_console
    r.pop_input_trans()
    ~~~~~~~~~~~~~~~~~^^
  File "/home/cfbolz/projects/cpython/Lib/_pyrepl/reader.py", line 546, in pop_input_trans
    self.input_trans = self.input_trans_stack.pop()
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~^^
IndexError: pop from empty list

This crashed pyrepl. I think it would be better if we printed the exception, but then actually stayed in pyrepl, to make sure we don't lose the repl state which might have been annoying to get to.

Another way to crash pyrepl, but not the classic repl is to close sys.stderr and then raising an exception.

We could make pyrepl less crash-prone that by adding an except BaseException around the pyrepl loop in run_multiline_interactive_console.

Any opinions, @pablogsal, @ambv?

CPython versions tested on:

3.13, CPython main branch

Operating systems tested on:

Linux

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 Lib/_pyrepl/simple_interact.py 中的 run_multiline_interactive_console 开始,然后跟踪 traceback 中显示的经过 reader.py 和 unix_console.py 的异常路径。重现 Ctrl-C/搜索失败以及 sys.stderr 已关闭的情况。当 pyrepl 报告异常并且在不丢失 REPL 状态的情况下仍可使用时,即表示完成。

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
cli
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。