make pyrepl more robust against crashes
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 77.2k
- Forks
- 35.9k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Bug report
Bug description:
This issue is motivated by a discussion with @serhiy-storchaka on #122456. Pyrepl/code.InteractiveInterpreter does not handle exceptions at various points, see the linked commend for an example.
Directly after writing this, I also got the following traceback that I now can't reproduce, by pressing ctrl-r then searching for a string, and then pressing ctrl-c at somehow the wrong point:
>>> Traceback (most recent call last):
File "/home/cfbolz/projects/cpython/Lib/_pyrepl/simple_interact.py", line 147, in run_multiline_interactive_console
statement = multiline_input(more_lines, ps1, ps2)
File "/home/cfbolz/projects/cpython/Lib/_pyrepl/readline.py", line 385, in multiline_input
return reader.readline()
~~~~~~~~~~~~~~~^^
File "/home/cfbolz/projects/cpython/Lib/_pyrepl/reader.py", line 773, in readline
self.handle1()
~~~~~~~~~~~~^^
File "/home/cfbolz/projects/cpython/Lib/_pyrepl/reader.py", line 730, in handle1
event = self.console.get_event(block)
File "/home/cfbolz/projects/cpython/Lib/_pyrepl/unix_console.py", line 391, in get_event
self.push_char(self.__read(1))
~~~~~~~~~~~^^^
File "/home/cfbolz/projects/cpython/Lib/_pyrepl/unix_console.py", line 203, in __read
self.input_buffer = os.read(self.input_fd, 10000)
~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
KeyboardInterrupt
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<frozen runpy>", line 198, in _run_module_as_main
File "<frozen runpy>", line 88, in _run_code
File "/home/cfbolz/projects/cpython/Lib/_pyrepl/__main__.py", line 6, in <module>
__pyrepl_interactive_console()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/cfbolz/projects/cpython/Lib/_pyrepl/main.py", line 59, in interactive_console
run_multiline_interactive_console(console)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^
File "/home/cfbolz/projects/cpython/Lib/_pyrepl/simple_interact.py", line 164, in run_multiline_interactive_console
r.pop_input_trans()
~~~~~~~~~~~~~~~~~^^
File "/home/cfbolz/projects/cpython/Lib/_pyrepl/reader.py", line 546, in pop_input_trans
self.input_trans = self.input_trans_stack.pop()
~~~~~~~~~~~~~~~~~~~~~~~~~~^^
IndexError: pop from empty list
This crashed pyrepl. I think it would be better if we printed the exception, but then actually stayed in pyrepl, to make sure we don't lose the repl state which might have been annoying to get to.
Another way to crash pyrepl, but not the classic repl is to close sys.stderr and then raising an exception.
We could make pyrepl less crash-prone that by adding an except BaseException around the pyrepl loop in run_multiline_interactive_console.
Any opinions, @pablogsal, @ambv?
CPython versions tested on:
3.13, CPython main branch
Operating systems tested on:
Linux
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza en Lib/_pyrepl/simple_interact.py, en run_multiline_interactive_console, y luego sigue las rutas de excepción a través de reader.py y unix_console.py que se muestran en el traceback. Reproduce el fallo de Ctrl-C/búsqueda y el caso de sys.stderr cerrado. Se considera terminado cuando pyrepl informa de la excepción y sigue siendo utilizable sin perder el estado del REPL.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- cli
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100