datetime: Stop Exposing Process-Global Objects in the datetime C-API
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 36k
- PR 合併指標
- PR 指標待擷取
描述
Feature or enhancement
Proposal:
The datetime module has its own C-API which is enabled with PyDateTime_IMPORT. From the docs:
Before using any of these functions, the header file datetime.h must be included in your source
(note that this is not included by Python.h), and the macro PyDateTime_IMPORT must be invoked,
usually as part of the module initialisation function. The macro puts a pointer to a C structure into
a static variable, PyDateTimeAPI, that is used by the following macros.
My main concern is that the PyDateTimeAPI struct is a process-global value, but it exposes object pointers (which should always be per-interpreter). We have worked around this in 3.13+, but it would be better if we could make the objects per-interpreter.
FTR, here are the objects exposed directly by PyDateTimeAPI:
- (static type)
PyDateTime_DateType - (static type)
PyDateTime_DateTimeType - (static type)
PyDateTime_TimeType - (static type)
PyDateTime_DeltaType - (static type)
PyDateTime_TZInfoType - (singleton)
utc_timezone(an instance ofPyDateTime_TimeZoneType)
exposed indirectly:
- (static type)
PyDateTime_TimeZoneType
In order to make these objects per-interpreter, it would require changes to the datetime C-API. [^1] I expect we would leave PyDateTime_IMPORT alone. Instead, we'd need to update the macros in datetime.h to get the objects from the module associated with the current interpreter. [^2]
[^1]: These would be ABI-incompatible changes, which wouldn't be a problem unless the datetime C-API is part of the limited API).
[^2]: Anyone who is accessing the PyDateTimeAPI struct directly would have to change their code. It might make sense to provide a getter function/macro for each of the objects.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
先從 datetime C-API 文件以及提案中描述的 datetime.h 巨集開始,接著檢查 PyDateTimeAPI 如何公開所列型別和 utc_timezone。完成的標準是這些物件按直譯器隔離,而 PyDateTime_IMPORT 維持不變,並且任何必要的 getter 或直接存取變更都已記錄並經過測試。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- c, python
- 領域
- api
- Issue 類型
- 功能
- 難度
- 5/5
- 預估耗時
- 一週以上
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 25/100