datetime: Stop Exposing Process-Global Objects in the datetime C-API
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 77.2k
- Forks
- 36k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Feature or enhancement
Proposal:
The datetime module has its own C-API which is enabled with PyDateTime_IMPORT. From the docs:
Before using any of these functions, the header file datetime.h must be included in your source
(note that this is not included by Python.h), and the macro PyDateTime_IMPORT must be invoked,
usually as part of the module initialisation function. The macro puts a pointer to a C structure into
a static variable, PyDateTimeAPI, that is used by the following macros.
My main concern is that the PyDateTimeAPI struct is a process-global value, but it exposes object pointers (which should always be per-interpreter). We have worked around this in 3.13+, but it would be better if we could make the objects per-interpreter.
FTR, here are the objects exposed directly by PyDateTimeAPI:
- (static type)
PyDateTime_DateType - (static type)
PyDateTime_DateTimeType - (static type)
PyDateTime_TimeType - (static type)
PyDateTime_DeltaType - (static type)
PyDateTime_TZInfoType - (singleton)
utc_timezone(an instance ofPyDateTime_TimeZoneType)
exposed indirectly:
- (static type)
PyDateTime_TimeZoneType
In order to make these objects per-interpreter, it would require changes to the datetime C-API. [^1] I expect we would leave PyDateTime_IMPORT alone. Instead, we'd need to update the macros in datetime.h to get the objects from the module associated with the current interpreter. [^2]
[^1]: These would be ABI-incompatible changes, which wouldn't be a problem unless the datetime C-API is part of the limited API).
[^2]: Anyone who is accessing the PyDateTimeAPI struct directly would have to change their code. It might make sense to provide a getter function/macro for each of the objects.
Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
No response
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza con la documentación de la datetime C-API y las macros de datetime.h descritas en la propuesta; después, inspecciona cómo PyDateTimeAPI expone los tipos enumerados y utc_timezone. Se considera terminado cuando esos objetos son por intérprete, mientras PyDateTime_IMPORT permanece sin cambios, y cualquier cambio necesario en los getters o en el acceso directo está documentado y probado.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- c, python
- Área
- api
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 25/100