Code object creation (const interning) can mutate tuples
未关闭
@encukou 已经在做这个了。
开始于 2024年7月18日。
type-bug
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 35.9k
- PR 合并指标
- PR 指标待抓取
描述
In https://github.com/python/cpython/issues/121863#issuecomment-2232849007, Mark suspected something is off in const interning for code objects. Indeed, there is. For example:
# a bit of setup
import sys
interned = sys.intern("foobar")
def f():
var = "foobar"
# my_tuple = (None, 'foobar'), but with an un-interned string
my_tuple = (None, str(b'foobar', 'ascii'))
print(id(my_tuple), id(my_tuple[1]))
# pass my_tuple as an input argument for a new code object
f.__code__.replace(co_consts=my_tuple)
# there's now a different object in the tuple!
print(id(my_tuple), id(my_tuple[1]))
I'm working on a change to:
- create new tuples instead of mutating old ones
- intern more strings before passing them to
PyCodeconstructors, so that we usually don't need to create new tuples
Linked PRs
- gh-122180
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。