Code object creation (const interning) can mutate tuples
Open
@encukou is already working on this.
Since Jul 18, 2024.
type-bug
- Dominant language
- Python
- Stars
- 77.2k
- Forks
- 35.9k
- PR merge metrics
- PR metrics pending
Description
In https://github.com/python/cpython/issues/121863#issuecomment-2232849007, Mark suspected something is off in const interning for code objects. Indeed, there is. For example:
# a bit of setup
import sys
interned = sys.intern("foobar")
def f():
var = "foobar"
# my_tuple = (None, 'foobar'), but with an un-interned string
my_tuple = (None, str(b'foobar', 'ascii'))
print(id(my_tuple), id(my_tuple[1]))
# pass my_tuple as an input argument for a new code object
f.__code__.replace(co_consts=my_tuple)
# there's now a different object in the tuple!
print(id(my_tuple), id(my_tuple[1]))
I'm working on a change to:
- create new tuples instead of mutating old ones
- intern more strings before passing them to
PyCodeconstructors, so that we usually don't need to create new tuples
Linked PRs
- gh-122180
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.