Deadlock when shutting down ThreadPoolExecutor from inside OS Signal handler
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 77.2k
- 分支
- 35.9k
- PR 合併指標
- PR 指標待擷取
描述
Bug report
Bug description:
When running the code below and sending a SIGTERM to the process results in what looks like a deadlock on the ThreadPoolExecutor._shutdown_lock. I guess the issue is that the SIGTERM is being handled in main thread while in the submit function where the _shutdown_lock is already locked. When I try calling shutdown inside the signal handler it waits forever.
TBH I'm not sure if this is a bug or expected behavior but I wanted to file this anyways. Thanks!
from concurrent.futures import ThreadPoolExecutor
import signal
def main():
with ThreadPoolExecutor(max_workers=2) as executor:
def __exit(signal, frame):
executor.shutdown(wait=True, cancel_futures=True)
signal.signal(signal.SIGTERM, __exit)
while True:
executor.submit(lambda: 1 + 1)
if __name__ == "__main__":
main()
AFTER sending SIGTERM to the process, this is what pystack shows:
(v) rbost@fedora:~/code/CheckDuplicate$ pystack remote 3431749
Traceback for thread 3431751 (python) [] (most recent call last):
(Python) File "/usr/lib64/python3.12/threading.py", line 1030, in _bootstrap
self._bootstrap_inner()
(Python) File "/usr/lib64/python3.12/threading.py", line 1073, in _bootstrap_inner
self.run()
(Python) File "/usr/lib64/python3.12/threading.py", line 1010, in run
self._target(*self._args, **self._kwargs)
(Python) File "/usr/lib64/python3.12/concurrent/futures/thread.py", line 89, in _worker
work_item = work_queue.get(block=True)
Traceback for thread 3431750 (python) [] (most recent call last):
(Python) File "/usr/lib64/python3.12/threading.py", line 1030, in _bootstrap
self._bootstrap_inner()
(Python) File "/usr/lib64/python3.12/threading.py", line 1073, in _bootstrap_inner
self.run()
(Python) File "/usr/lib64/python3.12/threading.py", line 1010, in run
self._target(*self._args, **self._kwargs)
(Python) File "/usr/lib64/python3.12/concurrent/futures/thread.py", line 89, in _worker
work_item = work_queue.get(block=True)
Traceback for thread 3431749 (python) [] (most recent call last):
(Python) File "/home/rbost/code/CheckDuplicate/test.py", line 18, in <module>
main()
(Python) File "/home/rbost/code/CheckDuplicate/test.py", line 14, in main
executor.submit(lambda: 1 + 1)
(Python) File "/usr/lib64/python3.12/concurrent/futures/thread.py", line 175, in submit
f = _base.Future()
(Python) File "/usr/lib64/python3.12/concurrent/futures/_base.py", line 328, in __init__
def __init__(self):
(Python) File "/home/rbost/code/CheckDuplicate/test.py", line 9, in __exit
executor.shutdown(wait=True, cancel_futures=True)
(Python) File "/usr/lib64/python3.12/concurrent/futures/thread.py", line 220, in shutdown
with self._shutdown_lock:
CPython versions tested on:
3.12
Operating systems tested on:
Linux
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
重現提供的 SIGTERM 範例,然後檢查 concurrent/futures/thread.py 中 ThreadPoolExecutor.submit()、shutdown() 和 _shutdown_lock 附近的程式碼。該 issue 沒有定義 signal handler 的預期行為,也沒有指定測試;要推進工作,需要就該行為達成共識,並新增一個回歸測試,證明可以在沒有所回報死結的情況下完成。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- backend, operating-systems
- Issue 類型
- 缺陷
- 難度
- 4/5
- 預估耗時
- 3-5 天
- 活躍度
- 停滯
- 描述清晰度
- 需要釐清
- 新手友好度
- 25/100