Deadlock when shutting down ThreadPoolExecutor from inside OS Signal handler
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 77.2k
- Forks
- 35.9k
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Bug report
Bug description:
When running the code below and sending a SIGTERM to the process results in what looks like a deadlock on the ThreadPoolExecutor._shutdown_lock. I guess the issue is that the SIGTERM is being handled in main thread while in the submit function where the _shutdown_lock is already locked. When I try calling shutdown inside the signal handler it waits forever.
TBH I'm not sure if this is a bug or expected behavior but I wanted to file this anyways. Thanks!
from concurrent.futures import ThreadPoolExecutor
import signal
def main():
with ThreadPoolExecutor(max_workers=2) as executor:
def __exit(signal, frame):
executor.shutdown(wait=True, cancel_futures=True)
signal.signal(signal.SIGTERM, __exit)
while True:
executor.submit(lambda: 1 + 1)
if __name__ == "__main__":
main()
AFTER sending SIGTERM to the process, this is what pystack shows:
(v) rbost@fedora:~/code/CheckDuplicate$ pystack remote 3431749
Traceback for thread 3431751 (python) [] (most recent call last):
(Python) File "/usr/lib64/python3.12/threading.py", line 1030, in _bootstrap
self._bootstrap_inner()
(Python) File "/usr/lib64/python3.12/threading.py", line 1073, in _bootstrap_inner
self.run()
(Python) File "/usr/lib64/python3.12/threading.py", line 1010, in run
self._target(*self._args, **self._kwargs)
(Python) File "/usr/lib64/python3.12/concurrent/futures/thread.py", line 89, in _worker
work_item = work_queue.get(block=True)
Traceback for thread 3431750 (python) [] (most recent call last):
(Python) File "/usr/lib64/python3.12/threading.py", line 1030, in _bootstrap
self._bootstrap_inner()
(Python) File "/usr/lib64/python3.12/threading.py", line 1073, in _bootstrap_inner
self.run()
(Python) File "/usr/lib64/python3.12/threading.py", line 1010, in run
self._target(*self._args, **self._kwargs)
(Python) File "/usr/lib64/python3.12/concurrent/futures/thread.py", line 89, in _worker
work_item = work_queue.get(block=True)
Traceback for thread 3431749 (python) [] (most recent call last):
(Python) File "/home/rbost/code/CheckDuplicate/test.py", line 18, in <module>
main()
(Python) File "/home/rbost/code/CheckDuplicate/test.py", line 14, in main
executor.submit(lambda: 1 + 1)
(Python) File "/usr/lib64/python3.12/concurrent/futures/thread.py", line 175, in submit
f = _base.Future()
(Python) File "/usr/lib64/python3.12/concurrent/futures/_base.py", line 328, in __init__
def __init__(self):
(Python) File "/home/rbost/code/CheckDuplicate/test.py", line 9, in __exit
executor.shutdown(wait=True, cancel_futures=True)
(Python) File "/usr/lib64/python3.12/concurrent/futures/thread.py", line 220, in shutdown
with self._shutdown_lock:
CPython versions tested on:
3.12
Operating systems tested on:
Linux
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Reproduce el ejemplo de SIGTERM proporcionado y, a continuación, inspecciona concurrent/futures/thread.py alrededor de ThreadPoolExecutor.submit(), shutdown() y _shutdown_lock. El issue no define el comportamiento esperado del manejador de señales ni nombra una prueba; para avanzar es necesario acordar ese comportamiento y añadir una prueba de regresión que demuestre la finalización sin el deadlock indicado.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- backend, operating-systems
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100