Fallback md5 is used, when trying hard to only use OpenSSL
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 77.2k
- 派生
- 36k
- PR 合并指标
- PR 指标待抓取
描述
Bug report
Bug description:
When
- OpenSSL is configured in FIPS mode
- recommended config is used to only load "base + fips" providers
- without the default provider
- CPython is compiled with
--with-builtin-hashlib-hashes=blake2to exclude fallback implementation of MD5
upon importing hashlib fails to create MD5 construct.
# python3.10 -c 'import hashlib'
ERROR:root:code for hash md5 was not found.
Traceback (most recent call last):
File "/usr/lib/python3.10/hashlib.py", line 137, in __get_openssl_constructor
f(usedforsecurity=False)
ValueError: [digital envelope routines] unsupported
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.10/hashlib.py", line 261, in <module>
globals()[__func_name] = __get_hash(__func_name)
File "/usr/lib/python3.10/hashlib.py", line 141, in __get_openssl_constructor
return __get_builtin_constructor(name)
File "/usr/lib/python3.10/hashlib.py", line 123, in __get_builtin_constructor
raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type md5
Reference implementation is upstream openssl 3.3.0, with enable-fips, fipsinstall completed and openssl.cnf set to
# cat /etc/ssl/openssl.cnf
config_diagnostics = 1
openssl_conf = openssl_init
.include /etc/ssl/fipsmodule.cnf
[openssl_init]
providers = provider_sect
alg_section = algorithm_sect
[provider_sect]
fips = fips_sect
base = base_sect
[base_sect]
activate = 1
[algorithm_sect]
default_properties = fips=yes
In essence, things work well only when "default + fips" providers are loaded, as then MD5 functions in OpenSSL are detected as available and are used at runtime and correctly get blocked.
When only "base + fips" providers are loaded, ValueError is raised by OpenSSL constructor, and instead fallback implementation used from _md5 module if it was compiled in.
It seems like the above configuration was not tested, however it can be made to work. CPython should try to load the "default" OpenSSL provider, to guarantee access to non-fips hashes.
Security concerns
This is FedRAMP/FIPS compliance by-pass. This issue may allow using md5 without specifying "usedforsecurity=False" on systems otherwise configured to be in FIPS-mode only. And is the primary reason why documentation mentions that certain distributors of python remove md5 module altogether.
CPython versions tested on:
3.10, 3.11, 3.12
Operating systems tested on:
Linux
Linked PRs
- gh-118236
- gh-118238
- gh-118239
- gh-118240
- gh-118264
- gh-127300
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 hashlib.py 中的 __get_openssl_constructor 和 __get_builtin_constructor 开始,然后检查此处所述 OpenSSL base+fips provider 配置下的 _md5 回退路径。继续之前,先审阅相关 PR:gh-118236、gh-118238、gh-118239、gh-118240、gh-118264 和 gh-127300;当在此配置下导入 hashlib 不再通过回退启用 MD5 时,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- cryptography, security
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 25/100