Fallback md5 is used, when trying hard to only use OpenSSL
Personne n'a encore pris cette issue.
- Langage dominant
- Python
- Étoiles
- 77.2k
- Forks
- 35.9k
- Métriques de merge des PR
- Métriques de PR en attente
Description
Bug report
Bug description:
When
- OpenSSL is configured in FIPS mode
- recommended config is used to only load "base + fips" providers
- without the default provider
- CPython is compiled with
--with-builtin-hashlib-hashes=blake2to exclude fallback implementation of MD5
upon importing hashlib fails to create MD5 construct.
# python3.10 -c 'import hashlib'
ERROR:root:code for hash md5 was not found.
Traceback (most recent call last):
File "/usr/lib/python3.10/hashlib.py", line 137, in __get_openssl_constructor
f(usedforsecurity=False)
ValueError: [digital envelope routines] unsupported
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/lib/python3.10/hashlib.py", line 261, in <module>
globals()[__func_name] = __get_hash(__func_name)
File "/usr/lib/python3.10/hashlib.py", line 141, in __get_openssl_constructor
return __get_builtin_constructor(name)
File "/usr/lib/python3.10/hashlib.py", line 123, in __get_builtin_constructor
raise ValueError('unsupported hash type ' + name)
ValueError: unsupported hash type md5
Reference implementation is upstream openssl 3.3.0, with enable-fips, fipsinstall completed and openssl.cnf set to
# cat /etc/ssl/openssl.cnf
config_diagnostics = 1
openssl_conf = openssl_init
.include /etc/ssl/fipsmodule.cnf
[openssl_init]
providers = provider_sect
alg_section = algorithm_sect
[provider_sect]
fips = fips_sect
base = base_sect
[base_sect]
activate = 1
[algorithm_sect]
default_properties = fips=yes
In essence, things work well only when "default + fips" providers are loaded, as then MD5 functions in OpenSSL are detected as available and are used at runtime and correctly get blocked.
When only "base + fips" providers are loaded, ValueError is raised by OpenSSL constructor, and instead fallback implementation used from _md5 module if it was compiled in.
It seems like the above configuration was not tested, however it can be made to work. CPython should try to load the "default" OpenSSL provider, to guarantee access to non-fips hashes.
Security concerns
This is FedRAMP/FIPS compliance by-pass. This issue may allow using md5 without specifying "usedforsecurity=False" on systems otherwise configured to be in FIPS-mode only. And is the primary reason why documentation mentions that certain distributors of python remove md5 module altogether.
CPython versions tested on:
3.10, 3.11, 3.12
Operating systems tested on:
Linux
Linked PRs
- gh-118236
- gh-118238
- gh-118239
- gh-118240
- gh-118264
- gh-127300
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez dans hashlib.py, au niveau de __get_openssl_constructor et __get_builtin_constructor, puis examinez le chemin de fallback _md5 dans la configuration OpenSSL base+fips provider décrite ici. Consultez les PR liés gh-118236, gh-118238, gh-118239, gh-118240, gh-118264 et gh-127300 avant de poursuivre ; la tâche est terminée lorsque l’importation de hashlib n’active plus MD5 via le fallback dans cette configuration.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- python
- Domaine
- cryptography, security
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 25/100