python-poetry / python-poetry/install.python-poetry.org

Install script prints misleading message when you already have the version specified by `--version`

Aperta
#117 0 commenti 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Lingua principale
Python
Stelle
255
Fork
65
Merge medio
2h 48m
PR unite (30g)
1

Descrizione

  • Poetry version: 1.5.1
  • Python version: 3.9.16
  • OS version and name: macOS 13.2.1
  • pyproject.toml: n/a
  • I am on the latest stable Poetry version, installed using a recommended method.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have consulted the FAQ and blog for any relevant entries or release notes.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

When installing Poetry from the curl'able script, it conflates "already have requested version" and "already have latest version", which is misleading. An example terminal session:

$ curl -sSL https://install.python-poetry.org | python3.9 - --version 1.5.0

[ snip ]

Installing Poetry (1.5.0): Done

Poetry (1.5.0) is installed now. Great!

You can test that everything is set up by executing:

`poetry --version`


$ curl -sSL https://install.python-poetry.org | python3.9 - --version 1.5.0
Retrieving Poetry metadata

The latest version (1.5.0) is already installed.


$ curl -sSL https://install.python-poetry.org | python3.9 -

[ snip ]

Installing Poetry (1.5.1): Done

Poetry (1.5.1) is installed now. Great!

You can test that everything is set up by executing:

`poetry --version`

1.5.1 is latest, but when I reinstall 1.5.0 explicitly, it calls it the "latest version (1.5.0)".

This was briefly misleading as I was fixing some install issues on my project this morning. The issues themselves were resolved by upgrading Poetry, but I didn't realize at first that this was an option because this version pinning was being done by a set-everything-up script and the logging, of course, implied that upgrading Poetry was not a potential solution.

I would suggest splitting the logging into a two branches for clarity:

  • The requested version (x.y.z) is already installed. The latest version is a.b.c.
  • The latest version (x.y.z) is already installed.

Guida per i contributori

Nessuna guida per i contributori indicizzata per questo repository

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia con lo script di installazione recuperabile tramite curl e riproduci entrambi i comandi usando una versione richiesta esplicitamente e la versione più recente predefinita. Segui il ramo che segnala una versione installata, quindi verifica che il messaggio distingua la versione richiesta dalla versione più recente e mantenga la formulazione esistente per la versione più recente.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
python
Ambito
cli, tooling
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Ferma
Chiarezza
Specificata chiaramente
Idoneità per principianti
45/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.