python-poetry / python-poetry/install.python-poetry.org

Install script prints misleading message when you already have the version specified by `--version`

Abierto
#117 0 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

Lenguaje dominante
Python
Estrellas
255
Forks
65
Merge medio
2 h 48 min
PR fusionados (30 d)
1

Descripción

  • Poetry version: 1.5.1
  • Python version: 3.9.16
  • OS version and name: macOS 13.2.1
  • pyproject.toml: n/a
  • I am on the latest stable Poetry version, installed using a recommended method.
  • I have searched the issues of this repo and believe that this is not a duplicate.
  • I have consulted the FAQ and blog for any relevant entries or release notes.
  • If an exception occurs when executing a command, I executed it again in debug mode (-vvv option) and have included the output below.

Issue

When installing Poetry from the curl'able script, it conflates "already have requested version" and "already have latest version", which is misleading. An example terminal session:

$ curl -sSL https://install.python-poetry.org | python3.9 - --version 1.5.0

[ snip ]

Installing Poetry (1.5.0): Done

Poetry (1.5.0) is installed now. Great!

You can test that everything is set up by executing:

`poetry --version`


$ curl -sSL https://install.python-poetry.org | python3.9 - --version 1.5.0
Retrieving Poetry metadata

The latest version (1.5.0) is already installed.


$ curl -sSL https://install.python-poetry.org | python3.9 -

[ snip ]

Installing Poetry (1.5.1): Done

Poetry (1.5.1) is installed now. Great!

You can test that everything is set up by executing:

`poetry --version`

1.5.1 is latest, but when I reinstall 1.5.0 explicitly, it calls it the "latest version (1.5.0)".

This was briefly misleading as I was fixing some install issues on my project this morning. The issues themselves were resolved by upgrading Poetry, but I didn't realize at first that this was an option because this version pinning was being done by a set-everything-up script and the logging, of course, implied that upgrading Poetry was not a potential solution.

I would suggest splitting the logging into a two branches for clarity:

  • The requested version (x.y.z) is already installed. The latest version is a.b.c.
  • The latest version (x.y.z) is already installed.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Empieza con el script de instalación descargable mediante curl y reproduce ambos comandos usando una versión solicitada explícitamente y la versión más reciente predeterminada. Sigue la rama que informa de una versión instalada y verifica después que el mensaje distingue la versión solicitada de la versión más reciente y conserva la redacción existente de la versión más reciente.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
python
Área
cli, tooling
Tipo de issue
Error
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.