pulp / pulp/pulp_python

Pull-through cache: `.whl.metadata` (PEP 658) requests raise `ValueError: True is not in list` on 3.29.0 — residual case of #1083

オープン
#1,219 コメント 1 件 リアクション 0 件 担当者 0 名 GitHub で見る

まだ誰も着手していません。

Issue
主要言語
Python
スター
49
フォーク
88
平均マージ
1日 10時間
マージ済み PR(30日)
31

説明

Version

  • pulp_python 3.29.0
  • pulpcore 3.108.0
  • Installation: container image (Pulp operator on Kubernetes)

Describe the bug

On a pull-through PyPI distribution, when a client requests <wheel>.whl.metadata (PEP 658), pulp-content raises ValueError: True is not in list in pulp_python/app/utils.py:get_project_metadata_from_file and returns a 5xx / aborted stream. A direct GET also surfaces a misleading 404 with an upstream URL that doesn't exist (https://pypi.org/simple/<package>/<wheel>.whl.metadata — PEP 658 metadata files live next to the wheel on files.pythonhosted.org/packages/<hash>/..., not under the simple index path).

This appears to be a residual case of #1083. PR #1086 fixed the .whl fetch path by passing suffix=filename into the temp file, so endswith(".whl") matches. But when the requested artifact is the .whl.metadata companion, init_from_artifact_and_relative_path is still called, path.name ends in .metadata, the temp file ends in .metadata, and DIST_EXTENSIONS has no .metadata entry — so .index(True) raises.

To Reproduce

  1. Configure a pull-through PyPI distribution:
pulp python remote create       --name pypi --url https://pypi.org/ --policy on_demand
pulp python distribution create --name pypi-proxy --base-path pypi --remote pypi                                                                                                                                                                      
  1. From a clean state (no cached package), request the PEP 658 metadata file directly:
curl -sk -o - -w "HTTP %{http_code}\n" \               
"https://<pulp>/pulp/content/<domain>/pypi/simple/ruff/ruff-0.12.12-py3-none-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata"                                                                                                               

Equivalent: run uv lock / uv sync against this distribution from a cold uv cache — uv issues .whl.metadata requests per PEP 658.
3. Observe a 404 to the client and the following traceback in pulp-content logs:

File "pulpcore/content/handler.py", line 1033, in _save_artifact                                                                                                                                                                                      
content = c_type.init_from_artifact_and_relative_path(artifact, rel_path)                                                                                                                                                                           
File "pulp_python/app/models.py", line 223, in init_from_artifact_and_relative_path
data = artifact_to_python_content_data(path.name, artifact, domain=get_domain())                                                                                                                                                                    
File "pulp_python/app/utils.py", line 273, in artifact_to_python_content_data
metadata = get_project_metadata_from_file(temp_file.name)                                                                                                                                                                                           
File "pulp_python/app/utils.py", line 195, in get_project_metadata_from_file
pkg_type_index = [filename.endswith(ext) for ext in extensions].index(True)                                                                                                                                                                         
ValueError: True is not in list                        

Expected behavior

Either:

  • The .metadata companion is served from upstream (fetched alongside / extracted from the wheel) so PEP 658 works through the pull-through cache, or
  • The request returns a clean 404 without invoking the python-package metadata extractor on a non-package file.

In both cases get_project_metadata_from_file should not be called with a filename whose extension isn't in DIST_EXTENSIONS.

Additional context

  • Original report and partial fix: #1083, PR #1086 ("Fix pull-through metadata serving and saving", merged 2026-02-06; backported to 3.24 in #1089).
  • Related: #1101 (PR #1102) — metadata file mismatched against wheel.
  • 3.29.0 source for artifact_to_python_content_data confirms the suffix=filename fix from #1086 is present, so the .whl path works; the .whl.metadata path bypasses that protection because filename itself ends in .metadata.
  • Likely fix direction: short-circuit the companion .metadata case before artifact_to_python_content_data is called (e.g. in init_from_artifact_and_relative_path when relative_path ends in .metadata), since those bytes already are the metadata and don't need extracting.
  • Effect on clients: uv resolutions against the pull-through distribution silently report "only <old-cached-version> is available" because per-version metadata fetches all crash server-side; only versions whose metadata happens to already be cached in Postgres remain visible.

コントリビューションガイド

コントリビューションガイドを開く

はじめの一歩

  1. issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
  2. 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
  3. リポジトリをフォークし、ブランチを切って変更します。
  4. issue 番号を参照したプルリクエストを送ります。

調査の方向性

Start in pulp_python/app/models.py at init_from_artifact_and_relative_path and pulp_python/app/utils.py at artifact_to_python_content_data and get_project_metadata_from_file; reproduce the cold-cache .whl.metadata request with curl or uv. Trace the companion metadata path and verify it no longer invokes the extractor for an unsupported extension, while the request either serves metadata or returns a clean 404 without the ValueError.

索引モデルが issue の本文から書いたものです。

評価

技術スタック
python
領域
backend
issue の種類
バグ
難易度
3/5
見積もり時間
1〜2日
活発さ
静か
明瞭さ
おおむね明確
初心者へのやさしさ
58/100

新しい issue をメールで受け取る

初心者向けの GitHub issue を短くまとめたダイジェスト。