pmndrs / pmndrs/react-postprocessing

Outline introducing lighting changes to my scene

Open
#112 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
1.4k
Forks
134
Avg merge
4m
Merged PRs (30d)
4

Description

I have a piece of code that using the outline conditionally as shown below.

      {highlight ? (
        <EffectComposer multisampling={8} autoClear={false}>
          <Outline
            pulseSpeed={2}
            selection={[myMesh2]}
            visibleEdgeColor="white"
            edgeStrength={100}
            width={1000}
          />
        </EffectComposer>
      ) : null}

The outline behaviour works correctly but it's introuducing weird lighting behaviours. The first image is before it triggers, the second image is while it's active and the third is disabled after being triggered at least once. Does anybody know what the cause of this is? This is the only post processing effect that's being used.
pp-proof

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the conditional EffectComposer and Outline snippet, then compare lighting before activation, while active, and after disabling it using the attached images as reference. Done means the cause of the lighting change is isolated and the scene lighting remains consistent when the effect is toggled.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, three.js, typescript
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.