plotly / plotly/plotly.py

Plotly Express constructor: in wide mode, lists passed to `x` and `y` params are mutated

未关闭
#4,117 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

bug P3
主要语言
Python
星标
18.8k
派生
2.8k
平均合并
16 小时 26 分钟
30 天内合并 PR
21

描述

When either the x or y parameters to the Plotly Express constructor are passed lists of values, they are mutated such that values are converted to string.

Expected behaviour: Plotly Express should not mutate objects supplied as arguments by the user.

Minimal example (tested on Plotly 5.13.1 and master branch):

from random import randrange
import pandas as pd
import plotly.express as px

cols, rows = list(range(3)), list(range(10))
print(cols)
df = pd.DataFrame({col: [randrange(100) for _row in rows] for col in cols})
px.bar(df, y=cols, barmode="group")
print(cols)

Before the px.bar() call, cols has the value [1, 2, 3] and afterwards it is ["1", "2", "3"]. The same behaviour occurs for the x param and also when using other plotting functions than pxbar() (I tried px.histogram()).

I did some poking around, and can see that in the function build_dataframe in plotly/express/_core.py, the some of the fields in the user supplied args have copies made (which would fix this issue), but that is only applied to args found in the array_attrables list, which is ["dimensions", "custom_data", "hover_data", "path", "wide_variable"], which does not include x and y.

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

调研方向

从 plotly/express/_core.py 开始阅读 build_dataframe,尤其关注 array_attrables 如何控制对用户提供参数的复制。使用 wide 模式下的 x 或 y 列表重现最小示例,然后验证原始列表保留其值,并且在构造函数调用后没有被转换为字符串。

由索引模型根据 Issue 内容生成。

评估

技术栈
pandas, python
领域
data-visualization
Issue 类型
缺陷
难度
3/5
预计耗时
1-2 天
活跃度
停滞
描述清晰度
描述清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。