holidays on week days behave incorrectly
未关闭
还没有人认领这个 Issue。
bug
P3
- 主要语言
- Python
- 星标
- 18.8k
- 派生
- 2.8k
- 平均合并
- 16 小时 26 分钟
- 30 天内合并 PR
- 21
描述
Hi Folks,
I am having issues when I have holidays on week days.
if I exclude weekends and have a holiday on Friday there is a bug
rangebreaks=[
# NOTE: Below values are bound (not single values), ie. hide x to y
dict(bounds=['sat', 'mon']), # hide weekends, eg. hide sat to before mon
dict(bounds=[18, 9], pattern='hour'), # hide hours outside of 9.30am-4pm
dict(values=["2021-04-02", "2021-12-25"]), # hide holidays (Christmas and New Year's, etc)
]
(This error originated from the built-in JavaScript code that runs Dash apps. Click to see the full stack trace or open your browser's console.)
TypeError: Cannot read property 'val' of undefined
at u (http://127.0.0.1:8050/_dash-component-suites/dash_core_components/async-plotlyjs.v1_15_0m1611086576.js:2:2417931)
at doAutoRange (http://127.0.0.1:8050/_dash-component-suites/dash_core_components/async-plotlyjs.v1_15_0m1611086576.js:2:2420435)
at Object.r.doAutoRangeAndConstraints (http://127.0.0.1:8050/_dash-component-suites/dash_core_components/async-plotlyjs.v1_15_0m1611086576.js:2:2400288)
at S (http://127.0.0.1:8050/_dash-component-suites/dash_core_components/async-plotlyjs.v1_15_0m1611086576.js:2:2374022)
at Object.c.syncOrAsync (http://127.0.0.1:8050/_dash-component-suites/dash_core_components/async-plotlyjs.v1_15_0m1611086576.js:2:2287218)
at http://127.0.0.1:8050/_dash-component-suites/dash_core_components/async-plotlyjs.v1_15_0m1611086576.js:2:2375512
at Object.c.syncOrAsync (http://127.0.0.1:8050/_dash-component-suites/dash_core_components/async-plotlyjs.v1_15_0m1611086576.js:2:2287218)
at Object.r.plot (http://127.0.0.1:8050/_dash-component-suites/dash_core_components/async-plotlyjs.v1_15_0m1611086576.js:2:2376077)
at Object.r.newPlot (http://127.0.0.1:8050/_dash-component-suites/dash_core_components/async-plotlyjs.v1_15_0m1611086576.js:2:2370936)
at Object.r.react (http://127.0.0.1:8050/_dash-component-suites/dash_core_components/async-plotlyjs.v1_15_0m1611086576.js:2:2380532)
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先,在 Dash 应用中复现报告的 rangebreaks 配置,并在包含工作日节假日时检查浏览器控制台。从 async-plotlyjs bundle 的 doAutoRange 路径追踪该故障;当星期五的节假日能够在不出现 TypeError 的情况下隐藏,同时周末和小时排除仍然有效时,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript, python
- 领域
- data-visualization
- Issue 类型
- 缺陷
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 活跃度
- 停滞
- 描述清晰度
- 基本清楚
- 新手友好度
- 35/100