plotly / plotly/plotly.js

[CHORE]: Reintegrate `stackgl_modules` into top level library

Open
#8,016 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

chore P3 plotly-internal size: 1 task
Dominant language
JavaScript
Stars
18.3k
Forks
2k
Avg merge
2d 12h
Merged PRs (30d)
28

Description

Description

Reintegrate the stackgl_modules sub-project into the top level library.

Why should this change be made?

This was originally moved to a subfolder in #6004 to allow for supporting older versions of Node and npm. That support is no longer required and moving this back would allow us to simplify the repo a bit.

Scope
  • Move dependencies into the root package.json
  • Update scripts to handle new location
Notes
  • It's possible that it would still be beneficial to leave this folder as is since it segregates some dev dependencies that most people don't need
  • This was mentioned as a potential option in #7862

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the root package.json and the stackgl_modules sub-project, then review the changes from #6004 and the alternative noted in #7862. Trace the scripts that reference the sub-project and run the existing build and test commands. Done means dependencies are handled from the root and the scripts work without the former Node/npm compatibility constraint.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, node.js
Domain
build-system, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.