plotly / plotly/plotly.R

Smith Chart with Plotly

Open
#2,126 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
R
Stars
2.7k
Forks
641
PR merge metrics
No merged PRs in 30d

Description

Hello,

I would like to implement Smith Charts using Plotly. This is the error I get when trying so.

ggplotly(ggplot(dipole,

  •      aes(freq = frequency, 
    
  •          smag = mag,
    
  •          sang = ang * pi / 180,
    
  •          color = frequency)) +
    
  • geom_smith())
    

from rftk example https://rdrr.io/github/aaronmanderson3/rftk/man/geom_smith.html

Error in eval(substitute(expr), data, enclos = parent.frame()) :
object 'tickvals' not found
In addition: Warning messages:
1: In min(z[["x"]]$dimension %()% z$x.range %||% z$x_range) :
no non-missing arguments to min; returning Inf
2: In max(z[["x"]]$dimension %()% z$x.range %||% z$x_range) :
no non-missing arguments to max; returning -Inf
3: In min(z[["y"]]$dimension %()% z$y.range %||% z$y_range) :
no non-missing arguments to min; returning Inf
4: In max(z[["y"]]$dimension %()% z$y.range %||% z$y_range) :
no non-missing arguments to max; returning -Inf
5: In geom2trace.default(dots[[1L]][[1L]], dots[[2L]][[1L]], dots[[3L]][[1L]]) :
geom_GeomSmith() has yet to be implemented in plotly.
If you'd like to see this geom implemented,
Please open an issue with your example code at
https://github.com/ropensci/plotly/issues

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the rftk geom_smith example and the ggplotly call in the issue, then inspect the geom2trace.default path that reports geom_GeomSmith() as unimplemented. Determine the required Plotly representation for the Smith Chart and verify that the example converts without the reported error and warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.