renderPlotly function gives two errors when running via do.call()
Ninguém assumiu esta issue ainda.
- Linguagem predominante
- R
- Estrelas
- 2.7k
- Forks
- 641
- Métricas de merge de PRs
- Nenhum PR com merge em 30d
Descrição
The renderPlotly function gives two errors when running it via do.call().
Thi first is that quoting done in renderPlotly doesn't seem to be accepted by the subsequent Shiny functions.
The second is because do.call adds another layer of frames the label = sys.call(-1)[[1]] in shiny::installExprFunction() does not correctly capture the function name for use as a label. This seems to be hardcoded in most shiny render functions such as renderPlot().
I think this is due to changes made in the shiny code to support quosures (https://github.com/rstudio/shiny/pull/3472). I don't have any experience with quoting and quosures but I put my current workaround at the end of the reprex.
library(plotly)
library(shiny)
a_plot <- plot_ly(x = 1:3, y = 2:4)
# Usual call of renderPlotly works
plot_redered <-renderPlotly(a_plot)
# Using do.call gives an error
plot_redered <-do.call(renderPlotly, list(expr = a_plot))
#> Error in exprToQuo(expr, env, quoted = TRUE): Don't know how to convert 'plotly' to a function; a quosure or quoted expression was expected
# Put the plot in a quosure gives a different error
q_plot <- rlang::quo(plot_ly(x = 1:3, y = 2:4))
plot_redered <-do.call(renderPlotly, list(expr = q_plot, quoted = T))
#> Error in as.character(label): cannot coerce type 'closure' to vector of type 'character'
# Modified function that manually specifies label = "renderPlotly" when calling shiny::installExprFunction and uses enquote() in place of substitute()
renderPlotly_w_label <- function (expr, env = parent.frame(), quoted = FALSE){
if (!quoted) {
quoted <- TRUE
expr <- enquote(expr)
}
shiny::installExprFunction(expr, "func", env, quoted, label = "renderPlotly")
expr2 <- quote(getFromNamespace("prepareWidget", "plotly")(func()))
renderFunc <- htmlwidgets::shinyRenderWidget(expr2, plotlyOutput, environment(),
quoted, cacheHint = list(label = "renderPlotly",
userExpr = expr))
shiny::snapshotPreprocessOutput(renderFunc, function(value) {
json <- from_JSON(value)
json$x <- json$x[setdiff(names(json$x), c("visdat",
"cur_data", "attrs"))]
to_JSON(json)
})
}
# This succeeds
plot_redered <-do.call(renderPlotly_w_label, list(expr = a_plot))
Created on 2022-02-17 by the reprex package (v2.0.1)
Standard output and standard error
[31mx[39m Install the [34mstyler[39m package in order to use `style = TRUE`.
Guia de contribuição
Primeiros passos
- Leia a issue inteira e depois o guia de contribuição do projeto.
- Comente na issue dizendo que vai assumir — evita que duas pessoas façam o mesmo trabalho.
- Faça um fork do repositório e trabalhe em uma branch.
- Abra um pull request que referencie o número da issue.
Direção de pesquisa
Comece pela função renderPlotly e reproduza os exemplos de do.call() na issue; em seguida, examine como shiny::installExprFunction lida com quoting, quosures e labels. O trabalho estará concluído quando renderPlotly funcionar por meio de do.call() sem nenhum dos dois erros relatados; nenhuma fonte específica nem teste específico é indicado na issue.
Escrita pelo modelo de indexação a partir do texto da issue.
Avaliação
- Stack de tecnologia
- r
- Domínio
- data-visualization
- Tipo de issue
- Bug
- Dificuldade
- 4/5
- Tempo estimado
- 3-5 dias
- Status de atividade
- Estagnada
- Clareza
- Razoavelmente clara
- Facilidade para iniciantes
- 30/100