renderPlotly function gives two errors when running via do.call()
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- R
- Estrellas
- 2.7k
- Forks
- 641
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
The renderPlotly function gives two errors when running it via do.call().
Thi first is that quoting done in renderPlotly doesn't seem to be accepted by the subsequent Shiny functions.
The second is because do.call adds another layer of frames the label = sys.call(-1)[[1]] in shiny::installExprFunction() does not correctly capture the function name for use as a label. This seems to be hardcoded in most shiny render functions such as renderPlot().
I think this is due to changes made in the shiny code to support quosures (https://github.com/rstudio/shiny/pull/3472). I don't have any experience with quoting and quosures but I put my current workaround at the end of the reprex.
library(plotly)
library(shiny)
a_plot <- plot_ly(x = 1:3, y = 2:4)
# Usual call of renderPlotly works
plot_redered <-renderPlotly(a_plot)
# Using do.call gives an error
plot_redered <-do.call(renderPlotly, list(expr = a_plot))
#> Error in exprToQuo(expr, env, quoted = TRUE): Don't know how to convert 'plotly' to a function; a quosure or quoted expression was expected
# Put the plot in a quosure gives a different error
q_plot <- rlang::quo(plot_ly(x = 1:3, y = 2:4))
plot_redered <-do.call(renderPlotly, list(expr = q_plot, quoted = T))
#> Error in as.character(label): cannot coerce type 'closure' to vector of type 'character'
# Modified function that manually specifies label = "renderPlotly" when calling shiny::installExprFunction and uses enquote() in place of substitute()
renderPlotly_w_label <- function (expr, env = parent.frame(), quoted = FALSE){
if (!quoted) {
quoted <- TRUE
expr <- enquote(expr)
}
shiny::installExprFunction(expr, "func", env, quoted, label = "renderPlotly")
expr2 <- quote(getFromNamespace("prepareWidget", "plotly")(func()))
renderFunc <- htmlwidgets::shinyRenderWidget(expr2, plotlyOutput, environment(),
quoted, cacheHint = list(label = "renderPlotly",
userExpr = expr))
shiny::snapshotPreprocessOutput(renderFunc, function(value) {
json <- from_JSON(value)
json$x <- json$x[setdiff(names(json$x), c("visdat",
"cur_data", "attrs"))]
to_JSON(json)
})
}
# This succeeds
plot_redered <-do.call(renderPlotly_w_label, list(expr = a_plot))
Created on 2022-02-17 by the reprex package (v2.0.1)
Standard output and standard error
[31mx[39m Install the [34mstyler[39m package in order to use `style = TRUE`.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza por la función renderPlotly y reproduce los ejemplos de do.call() del issue; después, inspecciona cómo shiny::installExprFunction gestiona el quoting, los quosures y las etiquetas. Se considera terminado cuando renderPlotly funciona mediante do.call() sin ninguno de los dos errores indicados; el issue no especifica ningún archivo fuente ni prueba concretos.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- r
- Área
- data-visualization
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 30/100