Microseconds to error log
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- C
- Estrellas
- 40.4k
- Forks
- 8.1k
- Merge medio
- 2 d 13 h
- PR fusionados (30 d)
- 96
Descripción
Description
Hi there,
Not sure if this is the right place to discuss the topic. Please, guide me to the proper place if this needs to be re-directed.
We have quite a high-loaded environment and we really want to see timestamps containing microseconds in our logs. It is easy to do for our custom logger but error messages from the PHP itself narrowed down to seconds (I'm talking about method php_log_err_with_severity()
In our repository, we have a hacky patch that adds microsecs in this log as well. Unfortunately, such a solution is not really a good approach to looking into the future.
I wanted to adopt our patch to share it with the community and potentially merge it into upstream but stumbled upon the fact that it isn't really straightforward to format a date with microseconds using the standard API available for an extension.
Basically, I found a couple of options:
-
We can instantiate a DateTime object and call
DateTime::format(). It looks working but it makes the logging function way more complicated and potentially heavy -
date_formatworks directly withtimelib_timeand can properly handle microsecs but it is hidden insideext/date/php_date.c, Not really sure if it's a good idea to make it public -
In theory, it is possible to add one more parameter to
php_format_datebut it'll break all the existing code. The change of signature doesn't look like a good option. However, we might be able to introduce another function if we want to encapsulate work withtimelib_timewithin theext/date.
Looking into the future, probably we would like to have this format configurable, if so it looks easy to do but still I can't see an easy way to handle the microseconds issue.
Could you please help me to find the right way and share your thoughts about this topic (maybe there are strong objections against such a change)?
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza leyendo php_log_err_with_severity() en main/main.c y el código de formateo de fechas en ext/date/php_date.c. Compara los enfoques disponibles descritos en el issue y determina qué API o diseño upstream es aceptable sin romper los callers existentes. Se considera terminado cuando el alcance y el camino de implementación para las marcas de tiempo de microsegundos del registro de errores estén acordados y sean aplicables.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- c, php
- Área
- backend
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 5/5
- Tiempo estimado
- Más de una semana
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100