Microseconds to error log
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- C
- Sterne
- 40.4k
- Forks
- 8.2k
- Ø Merge
- 2 T. 13 Std.
- Gemergte PRs (30 T.)
- 96
Beschreibung
Description
Hi there,
Not sure if this is the right place to discuss the topic. Please, guide me to the proper place if this needs to be re-directed.
We have quite a high-loaded environment and we really want to see timestamps containing microseconds in our logs. It is easy to do for our custom logger but error messages from the PHP itself narrowed down to seconds (I'm talking about method php_log_err_with_severity()
In our repository, we have a hacky patch that adds microsecs in this log as well. Unfortunately, such a solution is not really a good approach to looking into the future.
I wanted to adopt our patch to share it with the community and potentially merge it into upstream but stumbled upon the fact that it isn't really straightforward to format a date with microseconds using the standard API available for an extension.
Basically, I found a couple of options:
-
We can instantiate a DateTime object and call
DateTime::format(). It looks working but it makes the logging function way more complicated and potentially heavy -
date_formatworks directly withtimelib_timeand can properly handle microsecs but it is hidden insideext/date/php_date.c, Not really sure if it's a good idea to make it public -
In theory, it is possible to add one more parameter to
php_format_datebut it'll break all the existing code. The change of signature doesn't look like a good option. However, we might be able to introduce another function if we want to encapsulate work withtimelib_timewithin theext/date.
Looking into the future, probably we would like to have this format configurable, if so it looks easy to do but still I can't see an easy way to handle the microseconds issue.
Could you please help me to find the right way and share your thoughts about this topic (maybe there are strong objections against such a change)?
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Beginne mit dem Lesen von php_log_err_with_severity() in main/main.c und des Codes zur Datumsformatierung in ext/date/php_date.c. Vergleiche die im Issue beschriebenen verfügbaren Ansätze und bestimme, welche Upstream-API oder welches Design akzeptabel ist, ohne bestehende Aufrufer zu beeinträchtigen. Erledigt bedeutet, dass Umfang und Implementierungspfad für Mikrosekunden-Zeitstempel im Error-Log vereinbart und umsetzbar sind.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- c, php
- Bereich
- backend
- Issue-Typ
- Feature
- Schwierigkeit
- 5/5
- Geschätzter Aufwand
- Über eine Woche
- Aktivitätsstatus
- Veraltet
- Klarheit
- Muss geklärt werden
- Anfängerfreundlichkeit
- 25/100