Microseconds to error log
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 40.4k
- Forks
- 8.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 96
Description
Description
Hi there,
Not sure if this is the right place to discuss the topic. Please, guide me to the proper place if this needs to be re-directed.
We have quite a high-loaded environment and we really want to see timestamps containing microseconds in our logs. It is easy to do for our custom logger but error messages from the PHP itself narrowed down to seconds (I'm talking about method php_log_err_with_severity()
In our repository, we have a hacky patch that adds microsecs in this log as well. Unfortunately, such a solution is not really a good approach to looking into the future.
I wanted to adopt our patch to share it with the community and potentially merge it into upstream but stumbled upon the fact that it isn't really straightforward to format a date with microseconds using the standard API available for an extension.
Basically, I found a couple of options:
-
We can instantiate a DateTime object and call
DateTime::format(). It looks working but it makes the logging function way more complicated and potentially heavy -
date_formatworks directly withtimelib_timeand can properly handle microsecs but it is hidden insideext/date/php_date.c, Not really sure if it's a good idea to make it public -
In theory, it is possible to add one more parameter to
php_format_datebut it'll break all the existing code. The change of signature doesn't look like a good option. However, we might be able to introduce another function if we want to encapsulate work withtimelib_timewithin theext/date.
Looking into the future, probably we would like to have this format configurable, if so it looks easy to do but still I can't see an easy way to handle the microseconds issue.
Could you please help me to find the right way and share your thoughts about this topic (maybe there are strong objections against such a change)?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading php_log_err_with_severity() in main/main.c and the date-formatting code in ext/date/php_date.c. Compare the available approaches described in the issue and determine what upstream API or design is acceptable without breaking existing callers. Done means the scope and implementation path for microsecond error-log timestamps are agreed and actionable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, php
- Domain
- backend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100