SoapClient only strips `Authorization: Basic` when a WSDL imports from another host
@DanielEScherzer がすでに取り組んでいます。
2026年9月15日 から。
- 主要言語
- C
- スター
- 40.4k
- フォーク
- 8.1k
- 平均マージ
- 2日 13時間
- マージ済み PR(30日)
- 96
説明
Description
Originally reported by @christos-cantina-security.
When a WSDL imports a schema or another WSDL from a different host, SoapClient clears the credentials from the stream context before fetching it in sdl_set_uri_credentials() @ ext/soap/php_sdl.c. The strip only matches the exact string Authorization: Basic in http.header, and only when that option is a string. The TODO right above it already notes that the array form of http.header is not handled.
Any other credential passes through to the third-party host as-is: a Bearer or Digest Authorization header, a lowercase authorization: header, a Cookie header, a Proxy-Authorization header, and every header given as an array.
The following code, with https://a.example serving a WSDL that contains <xsd:import schemaLocation="https://b.example/schema.xsd"/>:
<?php
$client = new SoapClient('https://a.example/service.wsdl', [
'cache_wsdl' => WSDL_CACHE_NONE,
'stream_context' => stream_context_create([
'http' => ['header' => "Authorization: Bearer secret-token\r\n"],
]),
]);
Resulted in this request on b.example:
GET /schema.xsd HTTP/1.1
Host: b.example
Authorization: Bearer secret-token
But I expected the header to be dropped on the host change, like Authorization: Basic already is:
GET /schema.xsd HTTP/1.1
Host: b.example
This should be hardened on master, potentially introducing a BC break:
- strip every
Authorization,Proxy-AuthorizationandCookieheader, case-insensitively - handle the array form of
http.header, resolving the existingTODO - add a
SoapClientoption to keep the headers for setups where the same credentials serve both hosts - document the behavior change in
UPGRADING
PHP Version
master
Operating System
No response
コントリビューションガイド
はじめの一歩
- issue を最後まで読み、次にプロジェクトのコントリビューションガイドを読みます。
- 着手することを issue にコメントします — 二人が同じ作業をするのを防げます。
- リポジトリをフォークし、ブランチを切って変更します。
- issue 番号を参照したプルリクエストを送ります。
評価
この issue はまだ評価されていません。