`pdo_pgsql`: `DEALLOCATE` on statement destruct silently aborts enclosing transaction if it fails
- 主要语言
- C
- 星标
- 40.4k
- 派生
- 8.1k
- 平均合并
- 2 天 13 小时
- 30 天内合并 PR
- 96
描述
Description
Description
When a PDOStatement backed by a server-side prepared statement is destroyed inside an open transaction, pdo_pgsql issues PQexec("DEALLOCATE <name>") unconditionally. If that DEALLOCATE fails for any reason, the enclosing transaction is moved to the failed state by the server, and the user's subsequent COMMIT is silently returned as ROLLBACK. No exception is raised to PHP because the failing call is pdo_pgsql-internal, not user-initiated.
On stock PostgreSQL this is latent — DEALLOCATE <name> effectively never fails once you've successfully PREPAREd. But the code is not defensive about it, and on Postgres-compatible servers where DEALLOCATE <name> is not supported (Aurora DSQL, and plausibly others in the future), every prepared-statement user inside a transaction silently loses their data.
Reproduction
Any PDO code doing:
$pdo = new PDO("pgsql:host=...;dbname=...", $user, $pass, [
PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
// ATTR_EMULATE_PREPARES defaults to false for pgsql
]);
$pdo->exec("BEGIN");
$stmt = $pdo->prepare("INSERT INTO t VALUES (?)");
$stmt->execute([1]);
unset($stmt); // <-- pdo_pgsql sends DEALLOCATE here
$pdo->exec("COMMIT"); // <-- returns success; row is NOT persisted
will silently lose the row if the DEALLOCATE fails.
Wire-level evidence
Captured with PQtrace against Aurora DSQL (PostgreSQL 16-compatible server that rejects DEALLOCATE <name>):
F Query "BEGIN"
B CommandComplete "BEGIN"
B ReadyForQuery T ; in transaction
F Parse "pdo_stmt_00000001" "INSERT INTO t VALUES ($1)"
F Bind / Describe / Execute / Sync
B ParseComplete / BindComplete / CommandComplete "INSERT 0 1"
B ReadyForQuery T
F Query "DEALLOCATE pdo_stmt_00000001" ; pdo_pgsql destructor
B ErrorResponse C "0A000" M "DEALLOCATE <name> not supported"
B ReadyForQuery E ; TRANSACTION NOW FAILED
F Query "COMMIT"
B CommandComplete "ROLLBACK" ; PG semantics: commit-of-failed-tx = rollback
B ReadyForQuery I
From PHP's point of view execute() succeeded, COMMIT succeeded, errorInfo() is ["00000", null, null].
Environment I observed it in
- PHP 8.2.30
pdo_pgsqlcompiled against libpq 15 (glibc, Debian bookworm)- Aurora DSQL (PostgreSQL 16-compatible)
PHP Version
PHP 8.2.30 (cli) (built: Apr 22 2026 01:33:58) (NTS)
Copyright (c) The PHP Group
Zend Engine v4.2.30, Copyright (c) Zend Technologies
with Zend OPcache v8.2.30, Copyright (c), by Zend Technologies
Operating System
No response
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
评估
这个 Issue 还没有评估数据。