php / php/php-src

`pdo_pgsql`: `DEALLOCATE` on statement destruct silently aborts enclosing transaction if it fails

Offen
#21,869 8 Kommentare 0 Reaktionen 1 zugewiesene Person Auf GitHub ansehen

@devnexen arbeitet bereits daran.

Seit 24.4.2026.

  • #21870 von @devnexen — offen
Bug Extension: pdo_pgsql Status: Needs Triage
Vorherrschende Sprache
C
Sterne
40.4k
Forks
8.1k
Ø Merge
2 T. 13 Std.
Gemergte PRs (30 T.)
96

Beschreibung

Description

Description

When a PDOStatement backed by a server-side prepared statement is destroyed inside an open transaction, pdo_pgsql issues PQexec("DEALLOCATE <name>") unconditionally. If that DEALLOCATE fails for any reason, the enclosing transaction is moved to the failed state by the server, and the user's subsequent COMMIT is silently returned as ROLLBACK. No exception is raised to PHP because the failing call is pdo_pgsql-internal, not user-initiated.

On stock PostgreSQL this is latent — DEALLOCATE <name> effectively never fails once you've successfully PREPAREd. But the code is not defensive about it, and on Postgres-compatible servers where DEALLOCATE <name> is not supported (Aurora DSQL, and plausibly others in the future), every prepared-statement user inside a transaction silently loses their data.

Reproduction

Any PDO code doing:

$pdo = new PDO("pgsql:host=...;dbname=...", $user, $pass, [
    PDO::ATTR_ERRMODE => PDO::ERRMODE_EXCEPTION,
    // ATTR_EMULATE_PREPARES defaults to false for pgsql
]);

$pdo->exec("BEGIN");
$stmt = $pdo->prepare("INSERT INTO t VALUES (?)");
$stmt->execute([1]);
unset($stmt);                 // <-- pdo_pgsql sends DEALLOCATE here
$pdo->exec("COMMIT");         // <-- returns success; row is NOT persisted

will silently lose the row if the DEALLOCATE fails.

Wire-level evidence

Captured with PQtrace against Aurora DSQL (PostgreSQL 16-compatible server that rejects DEALLOCATE <name>):

F  Query           "BEGIN"
B  CommandComplete "BEGIN"
B  ReadyForQuery   T                                   ; in transaction

F  Parse "pdo_stmt_00000001" "INSERT INTO t VALUES ($1)"
F  Bind / Describe / Execute / Sync
B  ParseComplete / BindComplete / CommandComplete "INSERT 0 1"
B  ReadyForQuery   T

F  Query           "DEALLOCATE pdo_stmt_00000001"      ; pdo_pgsql destructor
B  ErrorResponse   C "0A000" M "DEALLOCATE <name> not supported"
B  ReadyForQuery   E                                   ; TRANSACTION NOW FAILED

F  Query           "COMMIT"
B  CommandComplete "ROLLBACK"                          ; PG semantics: commit-of-failed-tx = rollback
B  ReadyForQuery   I

From PHP's point of view execute() succeeded, COMMIT succeeded, errorInfo() is ["00000", null, null].

Environment I observed it in

  • PHP 8.2.30
  • pdo_pgsql compiled against libpq 15 (glibc, Debian bookworm)
  • Aurora DSQL (PostgreSQL 16-compatible)
PHP Version
PHP 8.2.30 (cli) (built: Apr 22 2026 01:33:58) (NTS)
  Copyright (c) The PHP Group
  Zend Engine v4.2.30, Copyright (c) Zend Technologies
      with Zend OPcache v8.2.30, Copyright (c), by Zend Technologies
Operating System

No response

Beitragsleitfaden

Beitragsleitfaden öffnen

Erste Schritte

  1. Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
  2. Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
  3. Forke das Repository und arbeite in einem Branch.
  4. Öffne einen Pull Request, der die Issue-Nummer nennt.

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.