php / php/php-src

Disable SHM reattachment

Aperta
#20,470 1 commento 2 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Feature Status: Needs Triage
Lingua principale
C
Stelle
40.4k
Fork
8.1k
Merge medio
2g 13h
PR unite (30g)
96

Descrizione

Description

I'm opening this issue to restart the discussion started by @cmb69 in https://github.com/php/php-src/pull/17838 and https://github.com/php/php-src/pull/7865.

SHM reattachment leads to a number of problems, and likely fails often in practice, so I would like to disable it.

The reason we have SHM reattachment is that Windows doesn't support fork(), so multi-process SAPIs spawn independent processes. Therefore each process needs to reattach the Opcache SHM of previous processes.

This comes with a number of problems:

  1. The SHM must be attached at the same address in all processes. If the address is not free in one process, reattachment can not happen.
  2. When ASLR is enabled, some addresses referenced by SHM are invalid (such as opcode handler addresses stored in op arrays). Therefore, reattachment fails when ASLR is enabled (source).
  3. The memory layout of each process can differ regardless of ASLR, for example when DLLs were loaded in a different order. Therefore, SHM can not usually reference addresses out of SHM. This leads to various Windows-specific workarounds and special cases in the code base. For example, the inheritance cache is disabled for sub-classes of internal classes.

Additionally, this makes preloading incompatible with Windows, which blocks https://github.com/php/php-src/pull/18204.

In cases 1 and 2, the process fails with a fatal error, or fallsback to file_cache_only mode (when enabled), which is slower. So processes can randomly fail or be slower.

Case 2 implies that reattachment fails most of the times, now that ASLR is enabled by default.

Because of these, I believe that it would be beneficial to disable reattachment entirely.

Here is the impact on existing ways to deploy PHP, and what changes are required before we can disable reattachment:

IIS + FastCGI

In this configuration IIS itself manages PHP processes. Unfortunately this enforces a process-based model, and reattachment is required so that concurrent requests share the same cache.

I suggest that we recommend other configurations for performance-sensitive deployments. Disabling reattachment wouldn't impact development setups, so we can continue to support this configuration without reattachment.

Nginx + FastCGI

In this configuration, php-cgi manages child processes itself. Therefore we can switch this SAPI to threads in ZTS builds so that reattachment is not necessary anymore. This would likely make the SAPI more resource-efficient on Windows as well.

Apache + mod_php

Uses mpm_winnt, which spawns a single process and multiple threads.

Therefore, reattachment should not be necessary.

See https://github.com/php/php-src/pull/7865.

Additionally, @cmb69 started the implementation of an isapi-based SAPI:

IIS + isapi

Threaded, doesn't need reattachment

See https://github.com/php/php-src/pull/17838.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia da ext/opcache/shared_alloc_win32.c e leggi le pull request collegate #17838 e #7865. Esamina in che modo il ricollegamento a SHM influisce su IIS, Nginx, Apache e sulla SAPI ISAPI proposta, quindi definisci le modifiche di deployment necessarie. Il lavoro è completato quando esistono un design concordato e un’implementazione che disabilitano il ricollegamento senza compromettere le configurazioni threaded supportate.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
c, php
Ambito
backend, operating-systems
Tipo di issue
Funzionalità
Difficoltà
5/5
Tempo stimato
Più di una settimana
Stato di attività
Ferma
Chiarezza
Da chiarire
Idoneità per principianti
25/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.