Disable SHM reattachment
Personne n'a encore pris cette issue.
- Langage dominant
- C
- Étoiles
- 40.4k
- Forks
- 8.1k
- Merge moyen
- 2 j 13 h
- PR mergées (30 j)
- 96
Description
Description
I'm opening this issue to restart the discussion started by @cmb69 in https://github.com/php/php-src/pull/17838 and https://github.com/php/php-src/pull/7865.
SHM reattachment leads to a number of problems, and likely fails often in practice, so I would like to disable it.
The reason we have SHM reattachment is that Windows doesn't support fork(), so multi-process SAPIs spawn independent processes. Therefore each process needs to reattach the Opcache SHM of previous processes.
This comes with a number of problems:
- The SHM must be attached at the same address in all processes. If the address is not free in one process, reattachment can not happen.
- When ASLR is enabled, some addresses referenced by SHM are invalid (such as opcode handler addresses stored in op arrays). Therefore, reattachment fails when ASLR is enabled (source).
- The memory layout of each process can differ regardless of ASLR, for example when DLLs were loaded in a different order. Therefore, SHM can not usually reference addresses out of SHM. This leads to various Windows-specific workarounds and special cases in the code base. For example, the inheritance cache is disabled for sub-classes of internal classes.
Additionally, this makes preloading incompatible with Windows, which blocks https://github.com/php/php-src/pull/18204.
In cases 1 and 2, the process fails with a fatal error, or fallsback to file_cache_only mode (when enabled), which is slower. So processes can randomly fail or be slower.
Case 2 implies that reattachment fails most of the times, now that ASLR is enabled by default.
Because of these, I believe that it would be beneficial to disable reattachment entirely.
Here is the impact on existing ways to deploy PHP, and what changes are required before we can disable reattachment:
IIS + FastCGI
In this configuration IIS itself manages PHP processes. Unfortunately this enforces a process-based model, and reattachment is required so that concurrent requests share the same cache.
I suggest that we recommend other configurations for performance-sensitive deployments. Disabling reattachment wouldn't impact development setups, so we can continue to support this configuration without reattachment.
Nginx + FastCGI
In this configuration, php-cgi manages child processes itself. Therefore we can switch this SAPI to threads in ZTS builds so that reattachment is not necessary anymore. This would likely make the SAPI more resource-efficient on Windows as well.
Apache + mod_php
Uses mpm_winnt, which spawns a single process and multiple threads.
Therefore, reattachment should not be necessary.
See https://github.com/php/php-src/pull/7865.
Additionally, @cmb69 started the implementation of an isapi-based SAPI:
IIS + isapi
Threaded, doesn't need reattachment
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par ext/opcache/shared_alloc_win32.c et lisez les pull requests liés #17838 et #7865. Examinez l’impact de la ré-connexion à SHM sur IIS, Nginx, Apache et la SAPI ISAPI proposée, puis définissez les changements de déploiement requis. Le travail est considéré comme terminé lorsqu’une conception et une implémentation convenues désactivent la ré-connexion sans casser les configurations threadées prises en charge.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- c, php
- Domaine
- backend, operating-systems
- Type d'issue
- Fonctionnalité
- Difficulté
- 5/5
- Temps estimé
- Plus d'une semaine
- Activité
- À l'abandon
- Clarté
- À clarifier
- Accessibilité débutants
- 25/100