php / php/php-src

Hard to figure out from an error message where incompatible method declarations meet

Aperta
#12,091 6 commenti 14 reazioni 1 assegnatario Vedi su GitHub

@derickr ci sta già lavorando.

Dal 31/8/2023.

Feature Status: Needs Triage
Lingua principale
C
Stelle
40.4k
Fork
8.2k
Merge medio
2g 13h
PR unite (30g)
96

Descrizione

Description

When we launch a PHP application, we might get a similar message:

Fatal error: Declaration of Baz::getId(): mixed must be compatible with Foo::getId(): int in /tmp/preview on line 13

When we look up the declarations of these methods, we get this:

interface Foo
{
    
    public function getId(): int;
    
}

abstract class Baz
{
    
    public function getId(): mixed
    {
        //...
    }
    
}

They have nothing in common, their existence on their own shouldn't be a problem for our application.

The problem is when they meet via a common child that both extends Baz and implements Foo:

class Lorem extends Baz implements Foo
{
    
}

The problem is that we don't learn about Lorem from the PHP error message which makes it really hard to find Loremin a large application.

Personally I solved it by enabling Xdebug in develop mode and looking at the stack trace. One (or both) of these two things would help to debug this problem in the future:

  1. Show fatal error stack trace in PHP out of the box, without requiring Xdebug.
  2. Somehow include Lorem too in this error message: Fatal error: Declaration of Baz::getId(): mixed must be compatible with Foo::getId(): int in /tmp/preview on line 13

3v4l.org link: https://3v4l.org/4iOYG

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.