Hard to figure out from an error message where incompatible method declarations meet
@derickr y travaille déjà.
Depuis le 31/8/2023.
- Langage dominant
- C
- Étoiles
- 40.4k
- Forks
- 8.1k
- Merge moyen
- 2 j 13 h
- PR mergées (30 j)
- 96
Description
Description
When we launch a PHP application, we might get a similar message:
Fatal error: Declaration of Baz::getId(): mixed must be compatible with Foo::getId(): int in /tmp/preview on line 13
When we look up the declarations of these methods, we get this:
interface Foo
{
public function getId(): int;
}
abstract class Baz
{
public function getId(): mixed
{
//...
}
}
They have nothing in common, their existence on their own shouldn't be a problem for our application.
The problem is when they meet via a common child that both extends Baz and implements Foo:
class Lorem extends Baz implements Foo
{
}
The problem is that we don't learn about Lorem from the PHP error message which makes it really hard to find Loremin a large application.
Personally I solved it by enabling Xdebug in develop mode and looking at the stack trace. One (or both) of these two things would help to debug this problem in the future:
- Show fatal error stack trace in PHP out of the box, without requiring Xdebug.
- Somehow include
Loremtoo in this error message:Fatal error: Declaration of Baz::getId(): mixed must be compatible with Foo::getId(): int in /tmp/preview on line 13
3v4l.org link: https://3v4l.org/4iOYG
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Évaluation
Cette issue n'a pas encore été évaluée.