Hard to figure out from an error message where incompatible method declarations meet
@derickr is already working on this.
Since Aug 31, 2023.
- Dominant language
- C
- Stars
- 40.4k
- Forks
- 8.1k
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 96
Description
Description
When we launch a PHP application, we might get a similar message:
Fatal error: Declaration of Baz::getId(): mixed must be compatible with Foo::getId(): int in /tmp/preview on line 13
When we look up the declarations of these methods, we get this:
interface Foo
{
public function getId(): int;
}
abstract class Baz
{
public function getId(): mixed
{
//...
}
}
They have nothing in common, their existence on their own shouldn't be a problem for our application.
The problem is when they meet via a common child that both extends Baz and implements Foo:
class Lorem extends Baz implements Foo
{
}
The problem is that we don't learn about Lorem from the PHP error message which makes it really hard to find Loremin a large application.
Personally I solved it by enabling Xdebug in develop mode and looking at the stack trace. One (or both) of these two things would help to debug this problem in the future:
- Show fatal error stack trace in PHP out of the box, without requiring Xdebug.
- Somehow include
Loremtoo in this error message:Fatal error: Declaration of Baz::getId(): mixed must be compatible with Foo::getId(): int in /tmp/preview on line 13
3v4l.org link: https://3v4l.org/4iOYG
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.