stream_copy_to_stream returns false when data copied is less than $maxlength
还没有人认领这个 Issue。
- 主要语言
- C
- 星标
- 40.4k
- 派生
- 8.1k
- 平均合并
- 2 天 13 小时
- 30 天内合并 PR
- 96
描述
Description
The following code:
<?php
$streaminput = popen("my_command", "r"); // Some command which has generated output that sometimes has less than the 10000 read size bytes of data (if you care, I was actually calling postgres's pg_dump)
$streamoutput = popen("another_command", "w"); // I was actually using input pipe (i.e. stdin) of command started with proc_open() here (actually it was gzip, and I used proc_open so that I could read stdout here too), but AFAIK, that's just a stream to stdin as is the case in this example)
stream_set_blocking($streamoutput, false);
$expectedPos = 0;
while (!feof($streaminput)) {
$copied = stream_copy_to_stream($streaminput, $streamoutput, 10000);
$expectedPos += $copied;
// if ($copied === false) { echo "\nCopied is false!";
// if ($copied === 0) { echo "\nCopied is 0!"; // This message never printed
if ($copied == 0) { // Note: I later discovered that the unexpected false return caused the branch to execute because of == instead of ===, even though the stream position had advanced.
echo ".";
sleep 1;
continue;
else {
echo "\nCopied $copied, Expected position $expectedPos, actual position " . ftell($streaminput);
}
}
Resulted in this output:
Copied 10000, Expected position 10000, actual position 10000
Copied 10000, Expected position 20000, actual position 20000
Copied 10000, Expected position 30000, actual position 30000.
Copied 10000, Expected position 40000, actual position 48192
Copied 10000, Expected position 50000, actual position 58192
But I expected this output instead:
Copied 10000, Expected position 10000, actual position 10000
Copied 10000, Expected position 20000, actual position 20000
Copied 10000, Expected position 30000, actual position 30000
Copied 8192, Expected position 38192, actual position 38192
Copied 10000, Expected position 48192, actual position 48192
Notice how, in the real output, when the dot appears after 30000 (suggesting 0 bytes were copied, in fact 8192 bytes appear to have been copied according to the position returned by ftell()) - you can confirm $copied is false by uncommenting the relevant lines.
Each time I got a "." in the output I observed that the actual stream position had advanced, but always by less than the 10000 .... if it advanced by 10000, the value of $copied was 10000 and I got the full message. (edit: I've confirmed this by printing ftell($inputstream) with the "." in my local code, but I've not updated the example code/output above)
Also note that $streaminput never got to an eof state, and appeared most time to have simply stopped adding to the stream, and I end up killing the php script with ^C
PHP Version
PHP 8.1.2-1ubuntu2.13 (cli) (built: Jun 28 2023 14:01:49) (NTS)
Operating System
Ubuntu 22.04.2 LTS \n \l (running on WSL in Windows 11)
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
首先,使用非阻塞输出流重现提供的 stream_copy_to_stream 示例,并检查 PHP 源代码中的 stream_copy_to_stream 入口点。当可用字节数少于 10000 时,将返回值与输入流位置进行比较。完成的标准是:部分复制会报告已复制的字节数,并且循环可以在不挂起的情况下到达 EOF。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- c, php
- 领域
- backend
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 45/100