stream_copy_to_stream returns false when data copied is less than $maxlength
Nessuno ha ancora preso questa issue.
- Lingua principale
- C
- Stelle
- 40.4k
- Fork
- 8.1k
- Merge medio
- 2g 13h
- PR unite (30g)
- 96
Descrizione
Description
The following code:
<?php
$streaminput = popen("my_command", "r"); // Some command which has generated output that sometimes has less than the 10000 read size bytes of data (if you care, I was actually calling postgres's pg_dump)
$streamoutput = popen("another_command", "w"); // I was actually using input pipe (i.e. stdin) of command started with proc_open() here (actually it was gzip, and I used proc_open so that I could read stdout here too), but AFAIK, that's just a stream to stdin as is the case in this example)
stream_set_blocking($streamoutput, false);
$expectedPos = 0;
while (!feof($streaminput)) {
$copied = stream_copy_to_stream($streaminput, $streamoutput, 10000);
$expectedPos += $copied;
// if ($copied === false) { echo "\nCopied is false!";
// if ($copied === 0) { echo "\nCopied is 0!"; // This message never printed
if ($copied == 0) { // Note: I later discovered that the unexpected false return caused the branch to execute because of == instead of ===, even though the stream position had advanced.
echo ".";
sleep 1;
continue;
else {
echo "\nCopied $copied, Expected position $expectedPos, actual position " . ftell($streaminput);
}
}
Resulted in this output:
Copied 10000, Expected position 10000, actual position 10000
Copied 10000, Expected position 20000, actual position 20000
Copied 10000, Expected position 30000, actual position 30000.
Copied 10000, Expected position 40000, actual position 48192
Copied 10000, Expected position 50000, actual position 58192
But I expected this output instead:
Copied 10000, Expected position 10000, actual position 10000
Copied 10000, Expected position 20000, actual position 20000
Copied 10000, Expected position 30000, actual position 30000
Copied 8192, Expected position 38192, actual position 38192
Copied 10000, Expected position 48192, actual position 48192
Notice how, in the real output, when the dot appears after 30000 (suggesting 0 bytes were copied, in fact 8192 bytes appear to have been copied according to the position returned by ftell()) - you can confirm $copied is false by uncommenting the relevant lines.
Each time I got a "." in the output I observed that the actual stream position had advanced, but always by less than the 10000 .... if it advanced by 10000, the value of $copied was 10000 and I got the full message. (edit: I've confirmed this by printing ftell($inputstream) with the "." in my local code, but I've not updated the example code/output above)
Also note that $streaminput never got to an eof state, and appeared most time to have simply stopped adding to the stream, and I end up killing the php script with ^C
PHP Version
PHP 8.1.2-1ubuntu2.13 (cli) (built: Jun 28 2023 14:01:49) (NTS)
Operating System
Ubuntu 22.04.2 LTS \n \l (running on WSL in Windows 11)
Guida per i contributori
Apri la guida per i contributori
Come iniziare
- Leggi tutta la issue e poi la guida ai contributi del progetto.
- Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
- Fai un fork del repository e lavora su un branch.
- Apri una pull request che faccia riferimento al numero della issue.
Direzione di ricerca
Inizia riproducendo l’esempio fornito di stream_copy_to_stream con un flusso di output non bloccante e ispeziona il punto di ingresso di stream_copy_to_stream nel codice sorgente di PHP. Confronta il valore restituito con la posizione del flusso di input quando sono disponibili meno di 10000 byte. Il lavoro è completato quando le copie parziali riportano il numero di byte copiati e il ciclo può raggiungere EOF senza bloccarsi.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- c, php
- Ambito
- backend
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Tranquilla
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 45/100