Unserialized objects use significantly more memory than ones created with the normal constructor
Personne n'a encore pris cette issue.
- Langage dominant
- C
- Étoiles
- 40.4k
- Forks
- 8.2k
- Merge moyen
- 2 j 15 h
- PR mergées (30 j)
- 103
Description
Description
Consider the following code:
class SomeClass {
public $a = 1;
public $b = 2;
public $c = 3;
public $d = 4;
public $e = 5;
public $f = 6;
}
$s1 = serialize(new SomeClass());
function new_object() {
return new SomeClass();
}
function unserialize_object() {
global $s1;
return unserialize($s1);
}
class OtherClass {
public $a = 1;
public $b = 2;
public $c = 3;
public $d = 4;
public $e = 5;
public $f = 6;
public function __unserialize(array $attrs) {
foreach ($attrs as $name => $value)
$this->$name = $value;
}
}
$s2 = serialize(new OtherClass());
function new_object_other() {
return new OtherClass();
}
function unserialize_object_other() {
global $s2;
return unserialize($s2);
}
foreach ([
'new_object', 'unserialize_object',
'new_object_other', 'unserialize_object_other',
] as $f) {
$arr = [];
for ($i = 0; $i < 50000; ++$i) {
$arr[] = $f();
}
echo $f, " ", memory_get_usage() >> 20, "\n";
}
SomeClass contains some data. new_object() will create an instance, while unserialize_object() will unserialize an instance of exactly the same state (see $s1). When an array of 50k elements is created with one or another, the output for memory usage is as follows:
new_object 10
unserialize_object 43
I.e. the 50k instances created with the constructor use 10M memory, while the unserialized ones 43M. It seems that some data structures that are used while unserializing are not freed. However, when unsetting $arr to destroy the instances, memory consumption will drop to 1M, as expected.
Now consider OtherClass which has the __unserialize method. Nothing fancy, it just sets the attributes as the default handler would do. new_object_other() and unserialize_object_other() replicate the same logic as explained above, but for the new class. Output in this case is
new_object_other 10
unserialize_object_other 10
That is, memory consumption is the same regardless of how the objects are created.
Surplus memory usage grows with the number of attributes.
Tested with 8.1.2 and 8.2.0. Can also be seen on https://3v4l.org/ .
PHP Version
8.2.0
Operating System
No response
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par exécuter le script PHP fourni et comparez memory_get_usage() pour new_object(), unserialize_object() et la variante __unserialize() sur 50 000 objets. Suivez les chemins serialize()/unserialize() impliqués dans la reproduction. Le travail est terminé lorsque les objets équivalents désérialisés par défaut ne conservent plus beaucoup plus de mémoire que les objets construits normalement.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- php
- Domaine
- backend
- Type d'issue
- Bug
- Difficulté
- 4/5
- Temps estimé
- 3-5 jours
- Activité
- À l'abandon
- Clarté
- Plutôt claire
- Accessibilité débutants
- 35/100