php / php/php-sdk-binary-tools
Reconsider the use of md5() and uniqid()
Nobody has claimed this yet.
- Dominant language
- M4
- Stars
- 116
- Forks
- 50
- PR merge metrics
- No merged PRs in 30d
Description
This has been triggered by the discussion regarding the vote to deprecate md5(), sha1() and uniqid().
We're using md5() and uniqid() for caching purposes, what might cause collisions, so perhaps increasing the entropy would be a good idea. To avoid overly long filenames, we might use base32 encoding (base64 encoding isn't suitable for case insensitive file systems), instead of base16.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by locating the cache filename generation that calls md5() and uniqid(), then review how filenames are constrained on case-insensitive file systems. Done means an agreed collision-resistant approach is implemented without producing overly long cache filenames, with relevant tests updated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100