If an input is probably rich text, we need to validate it

Open
#333 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript

Research direction

Start by reading the related discussions in chipper issues 1361 and 1355, then locate Rosetta 2's handling of likely rich-text input. Define the validation behavior for strings mixing LTR markup such as tags with RTL Arabic text, and verify that the relevant Rosetta 2 validation checks catch the reported ordering problem.

Written by the indexing model from the issue text.

Description

There were some Build a Nucleus ar_MA build errors. They were related to the way the string was translated. It had to do with having a string with both LTR (<sup> tags) and RTL (Arabic text). The way the user inputted the string looked correct, but the logical order of the string was incorrect. The issue where @jonathanolson discusses the BAN build failure is https://github.com/phetsims/chipper/issues/1361, but note there are other problems discussed there as well.

This issue is tangentially related to https://github.com/phetsims/chipper/issues/1355.

Right now, we should limit our focus to validating likely rich text. @jbphet and I are hoping we only have to implement this in Rosetta 2.

Dominant language
TypeScript
Stars
3
Forks
3
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from phetsims/rosetta

All issues in phetsims/rosetta

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.