phetsims / phetsims/rosetta

Investigate and potentially improve handling of blocked opening of new tab for "Test" feature

Open
#482 5 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

priority:5-deferred
Dominant language
TypeScript
Stars
3
Forks
3
PR merge metrics
No merged PRs in 30d

Description

When the user presses the "Test" button in order to try out their translation, our code opens a new tab and puts the translated simulation in it. In our last update to Rosetta we added a feature that allows the client code to log a problem in the server log, and I recently took a look and saw several instances of the following message:

phet-server2.int.colorado.edu rosetta[864582]: error: Client error reported: Unable to open new window

In fact, this occurred 15 times during the month of August.

We may want to investigate this and see if we can make it go away or at least provide the user with a helpful message if they run into this.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.