pharmaverse / pharmaverse/logrx
Update "A few words of caution" to include info on overload operators
Open
- Dominant language
- HTML
- Stars
- 48
- Forks
- 12
- Avg merge
- 20d 8h
- Merged PRs (30d)
- 1
Description
We currently don't support identifying functions defined using overload operators, so the labels function from the base package is found.
Looking at the common package, I'm not entirely sure what is happening, but @kodesiba was looking into it as well. I'm not sure this overload is a common or ideal practice, so I'm hesitant to add this functionality into the package.
Please let me know if you are more familiar with overloading and see things differently.
Our thought is we can add this to our "A few words of caution" section, to make this more clear.
Originally posted by @nicholas-masel in #272
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.