patternfly / patternfly/patternfly-react
Table - support for small toggle using ActionsColumn
还没有人认领这个 Issue。
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
描述
Compact tables should use compact actions to achieve proper alignment. Regular actions will result in a small misalignment.
The default menu toggle in ActionsColumn component doesn't appear to have support for changing its size, so it causes a misalignment when used in compact tables. It would be great to be able pass a prop to this component to control the default toggle size.
@thatblindgeye I opened this issue before I saw your comment in https://github.com/patternfly/patternfly/issues/7267#issuecomment-2552073848
not sure if we expose a way to adjust the size of a kebab toggle in a table -- EDIT: technically we do as you can pass a custom toggle in
Seems like it might be useful to support a small toggle here, but feel free to close this if you think passing a custom toggle resolves this issue. https://github.com/patternfly/patternfly-react/blob/4d61988b459a747a05cd27a56ceecfea65b87612/packages/react-table/src/components/Table/ActionsColumn.tsx#L101-L109
Jira Issue: PF-4559
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 packages/react-table/src/components/Table/ActionsColumn.tsx 开始,尤其关注 issue 中链接的默认 toggle 区域。将现有的 custom-toggle 路径与所请求的大小控制进行比较,然后验证紧凑型表格可以使用小型 toggle,且不会影响常规表格。当默认 toggle 支持所请求的大小,同时保持当前行为不变时,即表示完成。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- react, typescript
- 领域
- frontend
- Issue 类型
- 功能
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 活跃度
- 冷清
- 描述清晰度
- 基本清楚
- 新手友好度
- 72/100