patternfly / patternfly/patternfly-react
Table - support for small toggle using ActionsColumn
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Compact tables should use compact actions to achieve proper alignment. Regular actions will result in a small misalignment.
The default menu toggle in ActionsColumn component doesn't appear to have support for changing its size, so it causes a misalignment when used in compact tables. It would be great to be able pass a prop to this component to control the default toggle size.
@thatblindgeye I opened this issue before I saw your comment in https://github.com/patternfly/patternfly/issues/7267#issuecomment-2552073848
not sure if we expose a way to adjust the size of a kebab toggle in a table -- EDIT: technically we do as you can pass a custom toggle in
Seems like it might be useful to support a small toggle here, but feel free to close this if you think passing a custom toggle resolves this issue. https://github.com/patternfly/patternfly-react/blob/4d61988b459a747a05cd27a56ceecfea65b87612/packages/react-table/src/components/Table/ActionsColumn.tsx#L101-L109
Jira Issue: PF-4559
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in packages/react-table/src/components/Table/ActionsColumn.tsx, especially the default toggle area linked in the issue. Compare the existing custom-toggle path with the requested size control, then verify that compact tables can use a small toggle without affecting regular tables. Done means the default toggle supports the requested size while preserving current behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100