patternfly / patternfly/patternfly-react

Bug - Code Editor - React basic read-only sample does not match HTML sample

Aperta Adatta ai principianti
#12,441 2 commenti 1 reazione 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

Stale
Lingua principale
TypeScript
Stelle
862
Fork
392
Merge medio
4g 8h
PR unite (30g)
9

Descrizione

Describe the problem
There is a visual styling mismatch between the React and HTML implementations of the Code Editor component in a read-only state. Specifically, the React "Basic" sample (when set to read-only) does not match the styling shown on the HTML "Read-only" version. The HTML version renders the code area with a distinct gray background to signify its read-only status, whereas the React version only applies a gray border, leaving the code area background white.

How do you reproduce the problem?

  • Navigate to the PatternFly React Code Editor documentation (https://www.patternfly.org/components/code-editor#basic).

  • View the "Basic" example or configure a basic Code Editor with the isReadOnly prop set to true.

  • Observe the background color of the code input area (it remains white/transparent with only a gray border).

  • Navigate to the PatternFly HTML Code Editor documentation (https://www.patternfly.org/components/code-editor/html#read-only).

  • Observe that the HTML version applies a full gray background variant (.pf-v5-c-code-editor.pf-m-read-only or equivalent utility) to the entire editor body.

Expected behavior
The React CodeEditor component should visually match the HTML implementation when isReadOnly is active. It should render with the full gray background variant across the code area, consistently indicating to the user that the text cannot be edited.

Is this issue blocking you?
No, it is not strictly blocking, but it creates visual inconsistency across our application's forms.
Workaround: Manually passing a custom class or inline styles to force the background color to match the PatternFly read-only token variables.

Screenshots

image

image

What is your environment?

  • OS: macOS Sonoma
  • Browser: Chrome
  • Version: 6.5.1

What is your product and what release date are you targeting?
RHOAI 3.5

Any other information?
It appears the React wrapper might not be mapping the isReadOnly prop to the correct modifier class (pf-m-read-only) on the outer container element that the HTML version utilizes.


Jira Issue: PF-4267

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia con l’esempio React Code Editor Basic e con la relativa prop isReadOnly, quindi confrontalo con l’esempio HTML Code Editor Read-only collegato nell’issue. Verifica se lo stato di sola lettura applica lo stile pf-m-read-only al contenitore esterno dell’editor e verifica che l’area del codice React abbia lo stesso sfondo grigio della versione HTML.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
react, typescript
Ambito
frontend
Tipo di issue
Bug
Difficoltà
2/5
Tempo stimato
1-3 ore
Stato di attività
Tranquilla
Chiarezza
Abbastanza chiara
Idoneità per principianti
65/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.