patternfly / patternfly/patternfly-react
Bug - Code Editor - React basic read-only sample does not match HTML sample
Personne n'a encore pris cette issue.
- Langage dominant
- TypeScript
- Étoiles
- 862
- Forks
- 392
- Merge moyen
- 4 j 8 h
- PR mergées (30 j)
- 9
Description
Describe the problem
There is a visual styling mismatch between the React and HTML implementations of the Code Editor component in a read-only state. Specifically, the React "Basic" sample (when set to read-only) does not match the styling shown on the HTML "Read-only" version. The HTML version renders the code area with a distinct gray background to signify its read-only status, whereas the React version only applies a gray border, leaving the code area background white.
How do you reproduce the problem?
-
Navigate to the PatternFly React Code Editor documentation (https://www.patternfly.org/components/code-editor#basic).
-
View the "Basic" example or configure a basic Code Editor with the isReadOnly prop set to true.
-
Observe the background color of the code input area (it remains white/transparent with only a gray border).
-
Navigate to the PatternFly HTML Code Editor documentation (https://www.patternfly.org/components/code-editor/html#read-only).
-
Observe that the HTML version applies a full gray background variant (.pf-v5-c-code-editor.pf-m-read-only or equivalent utility) to the entire editor body.
Expected behavior
The React CodeEditor component should visually match the HTML implementation when isReadOnly is active. It should render with the full gray background variant across the code area, consistently indicating to the user that the text cannot be edited.
Is this issue blocking you?
No, it is not strictly blocking, but it creates visual inconsistency across our application's forms.
Workaround: Manually passing a custom class or inline styles to force the background color to match the PatternFly read-only token variables.
Screenshots
What is your environment?
- OS: macOS Sonoma
- Browser: Chrome
- Version: 6.5.1
What is your product and what release date are you targeting?
RHOAI 3.5
Any other information?
It appears the React wrapper might not be mapping the isReadOnly prop to the correct modifier class (pf-m-read-only) on the outer container element that the HTML version utilizes.
Jira Issue: PF-4267
Guide de contribution
Ouvrir le guide de contribution
Par où commencer
- Lisez l'issue en entier, puis le guide de contribution du projet.
- Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
- Forkez le dépôt et travaillez sur une branche.
- Ouvrez une pull request qui référence le numéro de l'issue.
Piste de recherche
Commencez par l’exemple React Code Editor Basic et sa prop isReadOnly, puis comparez-le avec l’exemple HTML Code Editor Read-only indiqué dans l’issue. Vérifiez si l’état en lecture seule applique le style pf-m-read-only au conteneur externe de l’éditeur et vérifiez que la zone de code React a le même arrière-plan gris que la version HTML.
Rédigé par le modèle d'indexation à partir du texte de l'issue.
Évaluation
- Stack technique
- react, typescript
- Domaine
- frontend
- Type d'issue
- Bug
- Difficulté
- 2/5
- Temps estimé
- 1-3 heures
- Activité
- Calme
- Clarté
- Plutôt claire
- Accessibilité débutants
- 65/100