patternfly / patternfly/patternfly-react

Improve tests for MultipleFileUpload

Abierto
#11,854 3 comentarios 0 reacciones 0 asignados Ver en GitHub

Nadie ha tomado este issue todavía.

PF Team Stale
Lenguaje dominante
TypeScript
Estrellas
862
Forks
392
Merge medio
4 d 8 h
PR fusionados (30 d)
9

Descripción

Describe the enhancement or change
Consumer reported the following:

Not really an issue, but I am puzzled by the slight behaviour change of the MultipleFileUpload component.
The onFileDrop callback sends an array of File objects, with properties like path. But it seems this propetrty
changed a little bit:
In PF5 I was getting for example: path: "image.png"
In PF6 I am getting: path: "./image.png"
That's not much of a change and is almost the same in a filesystem. But as I was using this info for the path of the object I am sending into Object Storage, it messed up my app a little bit.
Again, not an issue, I will handle it in my code, but I was wondering if there was a specific reason for this behaviour change? Which does not happen for single file upload btw, it's the plain name of the file only.

We use a third-party library for this piece of the component - we did bump from 14.2.3 to 14.3.5 between versions, so it's possible they changed the file name handling between versions. I don't see a big difference in our code. I do see that we have mostly snapshot tests for this component and do not test the third-party library functionality at all in our tests, so we wouldn't have caught this when we bumped the dependency. We could stand to improve our tests for this component in my opinion.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?
No - not blocking.


Jira Issue: PF-1855

Guía de contribución

Abrir la guía de contribución

Primeros pasos

  1. Lee el issue completo y luego la guía de contribución del proyecto.
  2. Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
  3. Haz un fork del repositorio y trabaja en una rama.
  4. Abre un pull request que haga referencia al número del issue.

Línea de trabajo

Comienza con el componente MultipleFileUpload y sus pruebas snapshot existentes. Revisa cómo se representa actualmente el comportamiento onFileDrop de la biblioteca de terceros y, después, añade cobertura específica para la ruta File devuelta y el contraste con la carga de un solo archivo. La tarea estará terminada cuando el comportamiento relevante esté probado, en lugar de estar cubierto únicamente por snapshots.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
react, typescript
Área
frontend, testing
Tipo de issue
Refactorización
Dificultad
3/5
Tiempo estimado
1-2 días
Estado de actividad
Tranquilo
Claridad
Bastante claro
Aptitud para principiantes
55/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.