patternfly / patternfly/patternfly-react

Improve tests for MultipleFileUpload

Open
#11,854 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

PF Team Stale
Dominant language
TypeScript
Stars
862
Forks
392
Avg merge
4d 8h
Merged PRs (30d)
9

Description

Describe the enhancement or change
Consumer reported the following:

Not really an issue, but I am puzzled by the slight behaviour change of the MultipleFileUpload component.
The onFileDrop callback sends an array of File objects, with properties like path. But it seems this propetrty
changed a little bit:
In PF5 I was getting for example: path: "image.png"
In PF6 I am getting: path: "./image.png"
That's not much of a change and is almost the same in a filesystem. But as I was using this info for the path of the object I am sending into Object Storage, it messed up my app a little bit.
Again, not an issue, I will handle it in my code, but I was wondering if there was a specific reason for this behaviour change? Which does not happen for single file upload btw, it's the plain name of the file only.

We use a third-party library for this piece of the component - we did bump from 14.2.3 to 14.3.5 between versions, so it's possible they changed the file name handling between versions. I don't see a big difference in our code. I do see that we have mostly snapshot tests for this component and do not test the third-party library functionality at all in our tests, so we wouldn't have caught this when we bumped the dependency. We could stand to improve our tests for this component in my opinion.

Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?
No - not blocking.


Jira Issue: PF-1855

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the MultipleFileUpload component and its existing snapshot tests. Review how the third-party library's onFileDrop behavior is currently represented, then add focused coverage for the returned File path and the contrast with single-file upload. Done means the relevant behavior is tested rather than covered only by snapshots.

Written by the indexing model from the issue text.

Assessment

Tech stack
react, typescript
Domain
frontend, testing
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.