patternfly / patternfly/patternfly-react
TextInput/TextinputGroup - consistent status/validation prop naming
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 862
- Forks
- 392
- Avg merge
- 4d 8h
- Merged PRs (30d)
- 9
Description
Describe the enhancement or change
Related to convo chain at https://github.com/patternfly/patternfly-react/pull/10815#discussion_r1697713753
Would also pertain to other components that have a status/validation type prop. We should align on:
-
whether the prop should be
statusorvalidation(personally would lean towards status) -
whether the prop type should only include valid class values, e.g. success, error/danger (another thing to align on), warning, info, and custom, or whether there should also be a "default" value to sort of unset it. If the latter, then does "default" make sense or should it be "none" or something else?
Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?
Any other information?
Jira Issue: PF-32
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked pull request discussion and the TextInput and TextinputGroup prop definitions. Review other components with status or validation props, then resolve the naming and allowed-value questions; done means the conventions are agreed and applied consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- react, typescript
- Domain
- design, frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100