openpharma / openpharma/crmPack
Test whether we can really use more than 5 CPU cores for simulations
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 22
- Forks
- 14
- Avg merge
- 1d 23h
- Merged PRs (30d)
- 5
Description
Currently there is a restriction that limits the number of parallel cores to 5. There may be a reason, but I experienced good performance and no problems using 32 cores in parallel. Therefore, I propose to change the maximum to 32. Or let the user override the maximum with a user specified value (probably the better way if the machine is used by more users and one don't want to highjack all cores 😊)
https://github.com/Roche/crmPack/blob/1874c075f8814a0832578c5affddd4a4985d3783/R/Design-methods.R#L191
https://github.com/Roche/crmPack/blob/1874c075f8814a0832578c5affddd4a4985d3783/R/Design-methods.R#L447
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect R/Design-methods.R at the referenced lines around 191 and 447 to understand where the five-core restriction is applied. Run a simulation using more than five parallel cores, then determine whether completion means raising the limit to 32 or allowing a user-specified maximum, with behavior verified for both constrained and higher-core runs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- r
- Domain
- performance
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100