ofURLFileLoader doesn't timeout or handle exceptions

Open
#1,312 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
cpp
Domain
networking

Research direction

Start at the ofURLFileLoader entry point and reproduce the problem with the network disconnected while OF_LOG_VERBOSE is enabled. Trace how the HTTP exception affects the request queue; done means the request no longer remains queued forever when the HTTP subsystem fails, with timeout or exception handling covering the reported case.

Written by the indexing model from the issue text.

Description

bug core section-internals

If you issue a URL to ofURLFileLoader and the http subsystem triggers an exception (no route to host is the easiest to test -- just unplug your network), then the URL request will sit in the request queue forever. Turn on OF_LOG_VERBOSE and watch the console output.

There should be better exception handling, and/or there should be a timeout of some kind.

Dominant language
C++
Stars
10.4k
Forks
2.6k
Avg merge
1d 21h
Merged PRs (30d)
9

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openframeworks/openFrameworks

All issues in openframeworks/openFrameworks

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.