openframeworks / openframeworks/openFrameworks
line that will never compile in ofGLRenderer
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 10.4k
- Forks
- 2.6k
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 9
Description
this line https://github.com/openframeworks/openFrameworks/blob/master/libs/openFrameworks/gl/ofGLRenderer.cpp#L115
will never get compiled as it is inside an #ifdef TARGET_OPENGLES which is already surrounded by a #ifndef TARGET_OPENGLES
This same line is correctly implemented further down inside the correct preprocessor block.
here https://github.com/openframeworks/openFrameworks/blob/master/libs/openFrameworks/gl/ofGLRenderer.cpp#L181
So just deleting the problematic line should make no harm.
all the best!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open libs/openFrameworks/gl/ofGLRenderer.cpp around lines 115 and 181, and compare the surrounding preprocessor blocks. Remove the unreachable line identified near line 115 while preserving the corresponding implementation in the later block. Confirm the file still compiles for the relevant renderer targets.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100