Fix uncrustify tests for humble
Open
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 27
- Forks
- 30
- PR merge metrics
- No merged PRs in 30d
Description
Bug report
Looks like a minor uncrustify discrepancy:
https://github.com/open-rmf/rmf_task/runs/8285620339?check_suite_focus=true#step:5:1738
Required information:
- Operating system and version:
- jammy
- OpenRMF installation type:
- source
- ROS distribution and version:
- humble
- ROS installation type:
- ros-tooling/setup-ros@v0.4
Description of the bug
https://github.com/open-rmf/rmf_task/runs/8285620339?check_suite_focus=true#step:5:1738
2: --- src/rmf_task/TaskPlanner.cpp
2: +++ src/rmf_task/TaskPlanner.cpp.uncrustify
2: @@ -541 +541,2 @@
2: - return {};
2: + return {}
2: + ;
Steps to reproduce the bug
Reproducible in CI runs. No tested in local.
Expected behavior
Tests pass.
Actual behavior
Test fails
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/rmf_task/TaskPlanner.cpp around line 541 and reproduce the uncrustify discrepancy from the linked CI run on humble. Check the formatting test and its configuration, then verify that the uncrustify tests pass without moving the semicolon onto a separate line.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- ci-cd, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100